summaryrefslogtreecommitdiffstats
path: root/src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2014-07-03 16:06:47 +0200
committerSven Gothel <[email protected]>2014-07-03 16:06:47 +0200
commitdf9ff7f340a5ab4e07efc613f5f264eeae63d4c7 (patch)
tree239ae276b82024b140428e6c0fe5d739fdd686a4 /src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java
parenteb47aaba63e3b1bf55f274a0f338f1010a017ae4 (diff)
Code Clean-Up based on our Recommended Settings (jogamp-scripting c47bc86ae2ee268a1f38c5580d11f93d7f8d6e74)
Code Clean-Up based on our Recommended Settings (jogamp-scripting c47bc86ae2ee268a1f38c5580d11f93d7f8d6e74) - Change non static accesses to static members using declaring type - Change indirect accesses to static members to direct accesses (accesses through subtypes) - Add final modifier to private fields - Add final modifier to method parameters - Add final modifier to local variables - Remove unnecessary casts - Remove unnecessary '$NON-NLS$' tags - Remove trailing white spaces on all lines
Diffstat (limited to 'src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java')
-rw-r--r--src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java22
1 files changed, 11 insertions, 11 deletions
diff --git a/src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java b/src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java
index f49e406..c930dff 100644
--- a/src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java
+++ b/src/java/jogamp/common/util/locks/RecursiveLockImpl01CompleteFair.java
@@ -43,7 +43,7 @@ import com.jogamp.common.util.locks.RecursiveLock;
public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
private static class WaitingThread {
- WaitingThread(Thread t) {
+ WaitingThread(final Thread t) {
thread = t;
signaledByUnlock = false;
}
@@ -59,11 +59,11 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
private final Thread getOwner() {
return getExclusiveOwnerThread();
}
- private final void setOwner(Thread t) {
+ private final void setOwner(final Thread t) {
setExclusiveOwnerThread(t);
}
- private final void setLockedStack(Throwable s) {
- List<Throwable> ls = LockDebugUtil.getRecursiveLockTrace();
+ private final void setLockedStack(final Throwable s) {
+ final List<Throwable> ls = LockDebugUtil.getRecursiveLockTrace();
if(s==null) {
ls.remove(lockedStack);
} else {
@@ -78,7 +78,7 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
/** stack trace of the lock, only used if DEBUG */
private Throwable lockedStack = null;
}
- private Sync sync = new Sync();
+ private final Sync sync = new Sync();
public RecursiveLockImpl01CompleteFair() {
}
@@ -102,7 +102,7 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
}
@Override
- public final boolean isOwner(Thread thread) {
+ public final boolean isOwner(final Thread thread) {
synchronized(sync) {
return sync.getOwner() == thread ;
}
@@ -155,7 +155,7 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
}
throw new RuntimeException("Waited "+TIMEOUT+"ms for: "+toString()+" - "+threadName(Thread.currentThread()));
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new RuntimeException("Interrupted", e);
}
}
@@ -187,14 +187,14 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
}
// enqueue at the start
- WaitingThread wCur = new WaitingThread(cur);
+ final WaitingThread wCur = new WaitingThread(cur);
sync.queue.add(0, wCur);
do {
final long t0 = System.currentTimeMillis();
try {
sync.wait(timeout);
timeout -= System.currentTimeMillis() - t0;
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
if( !wCur.signaledByUnlock ) {
sync.queue.remove(wCur); // O(n)
throw e; // propagate interruption not send by unlock
@@ -255,7 +255,7 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
}
@Override
- public final void unlock(Runnable taskAfterUnlockBeforeNotify) {
+ public final void unlock(final Runnable taskAfterUnlockBeforeNotify) {
synchronized(sync) {
validateLocked();
final Thread cur = Thread.currentThread();
@@ -314,6 +314,6 @@ public class RecursiveLockImpl01CompleteFair implements RecursiveLock {
private final String syncName() {
return "<"+Integer.toHexString(this.hashCode())+", "+Integer.toHexString(sync.hashCode())+">";
}
- private final String threadName(Thread t) { return null!=t ? "<"+t.getName()+">" : "<NULL>" ; }
+ private final String threadName(final Thread t) { return null!=t ? "<"+t.getName()+">" : "<NULL>" ; }
}