summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2015-09-22 00:54:01 +0200
committerSven Gothel <[email protected]>2015-09-22 00:54:01 +0200
commit0f08d051974d840ca898d7d0b888a679e4dee248 (patch)
tree8ef852c858668c7fc14bbf75cecbbd4a0a143109 /src
parent6c45f1dbeb875790056aef424b91b54440790a2b (diff)
Bug 1219: IOUtil.testDirExe: Disable 'existingExe' DEBUG_EXE feature by hardcoded 'DEBUG_EXE_EXISTING_FILE = false'
This is required for security, i.e. not allowing to execute any pre-existing files! In case we need to manually debug this issue, we can re-enable it manually and locally, but not in public builds!
Diffstat (limited to 'src')
-rw-r--r--src/java/com/jogamp/common/util/IOUtil.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/java/com/jogamp/common/util/IOUtil.java b/src/java/com/jogamp/common/util/IOUtil.java
index 62144fc..59b0c9d 100644
--- a/src/java/com/jogamp/common/util/IOUtil.java
+++ b/src/java/com/jogamp/common/util/IOUtil.java
@@ -65,12 +65,15 @@ public class IOUtil {
public static final boolean DEBUG;
private static final boolean DEBUG_EXE;
private static final boolean DEBUG_EXE_NOSTREAM;
+ private static final boolean DEBUG_EXE_EXISTING_FILE;
static {
Debug.initSingleton();
DEBUG = Debug.debug("IOUtil");
DEBUG_EXE = PropertyAccess.isPropertyDefined("jogamp.debug.IOUtil.Exe", true);
DEBUG_EXE_NOSTREAM = PropertyAccess.isPropertyDefined("jogamp.debug.IOUtil.Exe.NoStream", true);
+ // For security reasons, we have to hardcode this, i.e. disable this manual debug feature!
+ DEBUG_EXE_EXISTING_FILE = false; // PropertyAccess.isPropertyDefined("jogamp.debug.IOUtil.Exe.ExistingFile", true);
}
/** Std. temporary directory property key <code>java.io.tmpdir</code>. */
@@ -918,7 +921,7 @@ public class IOUtil {
final File exeTestFile;
final boolean existingExe;
try {
- final File permExeTestFile = DEBUG_EXE ? new File(dir, "jogamp_exe_tst"+getExeTestFileSuffix()) : null;
+ final File permExeTestFile = DEBUG_EXE_EXISTING_FILE ? new File(dir, "jogamp_exe_tst"+getExeTestFileSuffix()) : null;
if( null != permExeTestFile && permExeTestFile.exists() ) {
exeTestFile = permExeTestFile;
existingExe = true;