| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Also add a few more calls to the new internal setEmpty/setInfinite helpers.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
|
| |
Avoid the calls to updateBoundsStates when we know exactly what bounds we set in
the default cases. Also add a check to the (Bounds) constructor for an empty Bounds
argument and directly set the empty state.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
empty bounds
The following pattern:
BoundingBox temp = new BoundingBox();
temp.setLower(1.0, 1.0, 1.0);
temp.setUpper(-1.0, -1.0, -1.0);
Incurs 3 calls to updateBoundsStates internally (construction and each setter),
while calling with a null argument needs 0 calls, and zero floating-point comparisons.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
When setting an empty or infinite bounds, avoid the calls to updateBoundsStates
by setting the two booleans directly.
In addition, provide a fast-path to the (Bounds) constructor to create an empty
BoundingBox when passing a null Bounds.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
| |
Unify the two if/else branches into a single loop and expand the Array using
System.arrayCopy.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
|
|
| |
GeometryAtom
In all paths, if the RenderAtom is not scoped to the given View, we return null
and do not adjust the renderAtoms array. Make this clear with an early return.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You cannot lock updates to a member variable using itself if the reference is
ever changed. The renderAtoms array in GeomtryAtom is resized when it does not
have enough room for all the open views. This leads to crashes similar to the following:
Exception in thread "J3D-RenderStructureUpdateThread-5" java.lang.ArrayIndexOutOfBoundsException: 3
at javax.media.j3d.GeometryAtom.getRenderAtom(GeometryAtom.java:241)
at javax.media.j3d.RenderBin.processTransformChanged(RenderBin.java:3506)
at javax.media.j3d.RenderBin.processMessages(RenderBin.java:1772)
at javax.media.j3d.StructureUpdateThread.doWork(StructureUpdateThread.java:102)
at javax.media.j3d.J3dThread.run(J3dThread.java:275)
Use the existing lockObj in this class to synchronize access. This lock is already
being used to protect updates to the centroid update calculation, but both locked
sections are relatively short, if contention ends up being a problem, renderAtoms
could be changed to an ArrayList instead which can be resized.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
| |
The existing code was using instanceof as a null-check in practice, annotate the lists
and helper functions with explicit types and make the null checks more obvious.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
| |
- annotate the one method these two lists are passed to
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
| |
- small change to use toArray with an argument array
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
| |
Remove some unused variables as well.
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
| |
RenderBin
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
| |
Signed-off-by: Harvey Harrison <[email protected]>
|
|
|
|
|
|
|
| |
[original message]
issue 636 fixed by mcneillk
git-svn-id: https://svn.java.net/svn/j3d-core~svn/trunk@954 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
| |
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@952 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
|
|
|
|
| |
Submitted by: lamer77
Reviewed by: aces
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@948 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setNormal(..)
Submitted by: interactivemesh
Reviewed by: aces
GeometryArrayRetained : dirty flag isn't set in setNormal(..)
'dirtyFlag |= NORMAL_CHANGED;' is missing in GeometryArrayRetained.setNormal(int index, float normal[])
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@947 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
|
|
|
|
|
|
| |
a ShaderAttribute
Submitted by: interactivemesh
Reviewed by: aces
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@946 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't change the state
Obtained from: isse db
Submitted by: interactivemesh
Reviewed by: Aces
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@945 ba19aa83-45c5-6ac9-afd3-db810772062c
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cards
Submitted by: Aces
Despiste newer Intel video cards has specs for creating devices using hardware
vertex processing (HWVP), as Hardware TnL and shaders +2.x, Intel recomends
using Software Vertex Processing (SWVP).
Now D3D pipeline uses SWVP as default for Intel Video cards
git-svn-id: https://svn.java.net/svn/j3d-core~svn/branches/dev-1_6@944 ba19aa83-45c5-6ac9-afd3-db810772062c
|