From b562f7db6e3ee3abe71d622306ab2a41473ef94e Mon Sep 17 00:00:00 2001 From: Adam Domurad Date: Tue, 23 Apr 2013 12:56:13 -0400 Subject: Reproducer for incorrect AppContext context-classloader --- ChangeLog | 14 ++++ .../resources/AppContextHasJNLPClassLoader.html | 44 ++++++++++ .../resources/AppContextHasJNLPClassLoader.jnlp | 57 +++++++++++++ .../AppContextHasJNLPClassLoaderForJNLPApplet.jnlp | 61 ++++++++++++++ .../srcs/AppContextHasJNLPClassLoader.java | 88 ++++++++++++++++++++ .../AppContextHasJNLPClassLoaderTest.java | 97 ++++++++++++++++++++++ 6 files changed, 361 insertions(+) create mode 100644 tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.html create mode 100644 tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.jnlp create mode 100644 tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp create mode 100644 tests/reproducers/signed/AppContextHasJNLPClassLoader/srcs/AppContextHasJNLPClassLoader.java create mode 100644 tests/reproducers/signed/AppContextHasJNLPClassLoader/testcases/AppContextHasJNLPClassLoaderTest.java diff --git a/ChangeLog b/ChangeLog index 01f6d98..855642c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,17 @@ +2013-04-23 Adam Domurad + + * tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.html: + Test AppContext context classloader from HTML applet + * tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.jnlp: + Test AppContext context classloader from JNLP application + * tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp: + Test AppContext context classloader from JNLP applet + * tests/reproducers/signed/AppContextHasJNLPClassLoader/srcs/AppContextHasJNLPClassLoader.java: + Print out context classloader for thread & AppContext, for + current thread & Swing thread. + * tests/reproducers/signed/AppContextHasJNLPClassLoader/testcases/AppContextHasJNLPClassLoaderTest.java: + Test runner for AppContextHasJNLPClassLoader + 2013-04-23 Adam Domurad Ensure JarFile handles do not leak. diff --git a/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.html b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.html new file mode 100644 index 0000000..41ac527 --- /dev/null +++ b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.html @@ -0,0 +1,44 @@ + + +

+ + +

+ + diff --git a/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.jnlp b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.jnlp new file mode 100644 index 0000000..41648ca --- /dev/null +++ b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoader.jnlp @@ -0,0 +1,57 @@ + + + + + Test AppContext Classloader + IcedTea + + Test that AppContext's context classloader is a JNLPClassLoader + + + + + + + + + + diff --git a/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp new file mode 100644 index 0000000..3e40743 --- /dev/null +++ b/tests/reproducers/signed/AppContextHasJNLPClassLoader/resources/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp @@ -0,0 +1,61 @@ + + + + + Test AppContext Classloader + IcedTea + + Test that AppContext's context classloader is a JNLPClassLoader + + + + + + + + + + diff --git a/tests/reproducers/signed/AppContextHasJNLPClassLoader/srcs/AppContextHasJNLPClassLoader.java b/tests/reproducers/signed/AppContextHasJNLPClassLoader/srcs/AppContextHasJNLPClassLoader.java new file mode 100644 index 0000000..f8b041d --- /dev/null +++ b/tests/reproducers/signed/AppContextHasJNLPClassLoader/srcs/AppContextHasJNLPClassLoader.java @@ -0,0 +1,88 @@ +/* + Copyright (C) 2013 Red Hat, Inc. + + This file is part of IcedTea. + + IcedTea is free software; you can redistribute it and/or + modify it under the terms of the GNU General Public License as published by + the Free Software Foundation, version 2. + + IcedTea is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with IcedTea; see the file COPYING. If not, write to + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + 02110-1301 USA. + + Linking this library statically or dynamically with other modules is + making a combined work based on this library. Thus, the terms and + conditions of the GNU General Public License cover the whole + combination. + + As a special exception, the copyright holders of this library give you + permission to link this library with independent modules to produce an + executable, regardless of the license terms of these independent + modules, and to copy and distribute the resulting executable under + terms of your choice, provided that you also meet, for each linked + independent module, the terms and conditions of the license of that + module. An independent module is a module which is not derived from + or based on this library. If you modify this library, you may extend + this exception to your version of the library, but you are not + obligated to do so. If you do not wish to do so, delete this + exception statement from your version. + */ + +import java.applet.Applet; + +import sun.awt.AppContext; + +import java.awt.EventQueue; + +/* Hybrid applet/application */ +public class AppContextHasJNLPClassLoader extends Applet { + + /* + * Output the current context classloader, and the current AppContext's + * stored context classloader. + * + * The context classloader should never be the system classloader for a + * webstart application or applet in any thread. + */ + static void printClassloaders(String location) { + ClassLoader appContextClassLoader = AppContext.getAppContext().getContextClassLoader(); + ClassLoader threadContextClassLoader = Thread.currentThread().getContextClassLoader(); + + System.out.println(location + ": app context classloader == " + + appContextClassLoader.getClass().getSimpleName()); + System.out.println(location + ": thread context classloader == " + + threadContextClassLoader.getClass().getSimpleName()); + } + + /* Applet start point */ + @Override + public void start() { + try { + main(null); + } catch (Exception e) { + e.printStackTrace(); + } + } + + /* Application start point */ + public static void main(String[] args) throws Exception { + printClassloaders("main-thread"); + + EventQueue.invokeAndWait(new Runnable() { + public void run() { + printClassloaders("swing-thread"); + } + }); + + // NB: The following is for JNLP applets only + try { System.exit(0); } catch (Exception e) {e.printStackTrace(); } + } + +} diff --git a/tests/reproducers/signed/AppContextHasJNLPClassLoader/testcases/AppContextHasJNLPClassLoaderTest.java b/tests/reproducers/signed/AppContextHasJNLPClassLoader/testcases/AppContextHasJNLPClassLoaderTest.java new file mode 100644 index 0000000..1dad7e8 --- /dev/null +++ b/tests/reproducers/signed/AppContextHasJNLPClassLoader/testcases/AppContextHasJNLPClassLoaderTest.java @@ -0,0 +1,97 @@ +/* +Copyright (C) 2013 Red Hat, Inc. + +This file is part of IcedTea. + +IcedTea is free software; you can redistribute it and/or +modify it under the terms of the GNU General Public License as published by +the Free Software Foundation, version 2. + +IcedTea is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with IcedTea; see the file COPYING. If not, write to +the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +02110-1301 USA. + +Linking this library statically or dynamically with other modules is +making a combined work based on this library. Thus, the terms and +conditions of the GNU General Public License cover the whole +combination. + +As a special exception, the copyright holders of this library give you +permission to link this library with independent modules to produce an +executable, regardless of the license terms of these independent +modules, and to copy and distribute the resulting executable under +terms of your choice, provided that you also meet, for each linked +independent module, the terms and conditions of the license of that +module. An independent module is a module which is not derived from +or based on this library. If you modify this library, you may extend +this exception to your version of the library, but you are not +obligated to do so. If you do not wish to do so, delete this +exception statement from your version. + */ + +import net.sourceforge.jnlp.annotations.KnownToFail; +import net.sourceforge.jnlp.annotations.TestInBrowsers; + +import net.sourceforge.jnlp.annotations.Bug; + +import org.junit.Assert; + +import net.sourceforge.jnlp.ServerAccess.AutoClose; + +import net.sourceforge.jnlp.browsertesting.BrowserTest; +import net.sourceforge.jnlp.browsertesting.Browsers; + +import net.sourceforge.jnlp.ProcessResult; + +import org.junit.Test; + +public class AppContextHasJNLPClassLoaderTest extends BrowserTest { + + private static final String MAIN_APP_CONTEXT_CLASSLOADER = "main-thread: app context classloader == JNLPClassLoader"; + private static final String MAIN_THREAD_CONTEXT_CLASSLOADER = "main-thread: thread context classloader == JNLPClassLoader"; + + private static final String SWING_APP_CONTEXT_CLASSLOADER = "swing-thread: app context classloader == JNLPClassLoader"; + private static final String SWING_THREAD_CONTEXT_CLASSLOADER = "swing-thread: thread context classloader == JNLPClassLoader"; + + private void assertHasJNLPClassLoaderAsContextClassloader(ProcessResult pr) { + // This shouldn't fail even with PR1251 + // If the main thread does not have the right context classloader, something is quite wrong + Assert.assertTrue("stdout should contains '" + MAIN_THREAD_CONTEXT_CLASSLOADER + "', but did not", pr.stdout.contains(MAIN_THREAD_CONTEXT_CLASSLOADER)); + + // PR1251 + Assert.assertTrue("stdout should contains '" + MAIN_APP_CONTEXT_CLASSLOADER + "', but did not", pr.stdout.contains(MAIN_APP_CONTEXT_CLASSLOADER)); + Assert.assertTrue("stdout should contains '" + SWING_APP_CONTEXT_CLASSLOADER + "', but did not", pr.stdout.contains(SWING_APP_CONTEXT_CLASSLOADER)); + Assert.assertTrue("stdout should contains '" + SWING_THREAD_CONTEXT_CLASSLOADER + "', but did not", pr.stdout.contains(SWING_THREAD_CONTEXT_CLASSLOADER)); + } + + @Test + @KnownToFail + @Bug(id="PR1251") + public void testJNLPApplicationAppContext() throws Exception { + ProcessResult pr = server.executeJavawsHeadless("/AppContextHasJNLPClassLoader.jnlp"); + assertHasJNLPClassLoaderAsContextClassloader(pr); + } + + @Test + @KnownToFail // EventQueue.invokeAndWait is broken in JNLP applets, see PR1253 + @Bug(id={"PR1251","PR1253"}) + public void testJNLPAppletAppContext() throws Exception { + ProcessResult pr = server.executeJavaws("/AppContextHasJNLPClassLoaderForJNLPApplet.jnlp"); + assertHasJNLPClassLoaderAsContextClassloader(pr); + } + + @Test + @TestInBrowsers(testIn={Browsers.one}) + @KnownToFail + @Bug(id="PR1251") + public void testAppletAppContext() throws Exception { + ProcessResult pr = server.executeBrowser("/AppContextHasJNLPClassLoader.html", AutoClose.CLOSE_ON_CORRECT_END); + assertHasJNLPClassLoaderAsContextClassloader(pr); + } +} -- cgit v1.2.3