From b42384fe344b0af2a54eb00735f7d59b6ba1ab6e Mon Sep 17 00:00:00 2001 From: Adam Domurad Date: Thu, 17 May 2012 14:14:03 -0400 Subject: Went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls. --- netx/net/sourceforge/jnlp/JNLPFile.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'netx/net/sourceforge/jnlp/JNLPFile.java') diff --git a/netx/net/sourceforge/jnlp/JNLPFile.java b/netx/net/sourceforge/jnlp/JNLPFile.java index 714ff7e..5ddb989 100644 --- a/netx/net/sourceforge/jnlp/JNLPFile.java +++ b/netx/net/sourceforge/jnlp/JNLPFile.java @@ -208,7 +208,7 @@ public class JNLPFile { //(i.e. If the jnlp file being launched exist locally, but it //originated from a website, then download the one from the website //into the cache). - if (sourceLocation != null && location.getProtocol() == "file") { + if (sourceLocation != null && "file".equals(location.getProtocol())) { openURL(sourceLocation, version, policy); } -- cgit v1.2.3