aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2014-07-08 23:17:03 +0200
committerSven Gothel <[email protected]>2014-07-08 23:17:03 +0200
commit59125627b731705f656c1aac99d08b864665b445 (patch)
tree59297b48503e504d845c7dbfd0a9a2e5e927babe
parent947bf9c45261013d81cc7199cb71c89b88b18fdf (diff)
Findbugs: Comment on some issues (OK, they are) ; Remove dead branches
-rw-r--r--src/jogl/classes/jogamp/graph/font/typecast/ot/table/PostTable.java4
-rw-r--r--src/newt/classes/jogamp/newt/driver/android/event/AndroidNewtEventFactory.java2
-rw-r--r--src/newt/classes/jogamp/newt/driver/bcm/vc/iv/ScreenDriver.java4
-rw-r--r--src/newt/classes/jogamp/newt/driver/kd/ScreenDriver.java4
4 files changed, 7 insertions, 7 deletions
diff --git a/src/jogl/classes/jogamp/graph/font/typecast/ot/table/PostTable.java b/src/jogl/classes/jogamp/graph/font/typecast/ot/table/PostTable.java
index faeecf909..f4dd31465 100644
--- a/src/jogl/classes/jogamp/graph/font/typecast/ot/table/PostTable.java
+++ b/src/jogl/classes/jogamp/graph/font/typecast/ot/table/PostTable.java
@@ -330,8 +330,8 @@ public class PostTable implements Table {
psGlyphName[i] = new String(buf);
}
}
- } else if (version == 0x00025000) {
- } else if (version == 0x00030000) {
+ // } else if (version == 0x00025000) {
+ // } else if (version == 0x00030000) {
}
}
diff --git a/src/newt/classes/jogamp/newt/driver/android/event/AndroidNewtEventFactory.java b/src/newt/classes/jogamp/newt/driver/android/event/AndroidNewtEventFactory.java
index 05191e200..579edc590 100644
--- a/src/newt/classes/jogamp/newt/driver/android/event/AndroidNewtEventFactory.java
+++ b/src/newt/classes/jogamp/newt/driver/android/event/AndroidNewtEventFactory.java
@@ -277,7 +277,7 @@ public class AndroidNewtEventFactory {
}
if( event.getPressure() > maxPressure ) {
- maxPressure = event.getPressure();
+ maxPressure = event.getPressure(); // write to static field intended
}
//
diff --git a/src/newt/classes/jogamp/newt/driver/bcm/vc/iv/ScreenDriver.java b/src/newt/classes/jogamp/newt/driver/bcm/vc/iv/ScreenDriver.java
index 5c1c08ca8..e3e854cba 100644
--- a/src/newt/classes/jogamp/newt/driver/bcm/vc/iv/ScreenDriver.java
+++ b/src/newt/classes/jogamp/newt/driver/bcm/vc/iv/ScreenDriver.java
@@ -107,8 +107,8 @@ public class ScreenDriver extends ScreenImpl {
/** Called from {@link #initNative()}. */
protected void setScreenSize(final int width, final int height) {
- cachedWidth = width;
- cachedHeight = height;
+ cachedWidth = width; // write to static field intended
+ cachedHeight = height; // write to static field intended
}
private static int cachedWidth = 0;
diff --git a/src/newt/classes/jogamp/newt/driver/kd/ScreenDriver.java b/src/newt/classes/jogamp/newt/driver/kd/ScreenDriver.java
index 06485ccef..71f8b1439 100644
--- a/src/newt/classes/jogamp/newt/driver/kd/ScreenDriver.java
+++ b/src/newt/classes/jogamp/newt/driver/kd/ScreenDriver.java
@@ -111,8 +111,8 @@ public class ScreenDriver extends ScreenImpl {
}
protected void sizeChanged(final int w, final int h) {
- cachedWidth = w;
- cachedHeight = h;
+ cachedWidth = w; // write to static field intended
+ cachedHeight = h; // write to static field intended
}
private static int cachedWidth = 0;