aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2014-07-08 12:38:53 +0200
committerSven Gothel <[email protected]>2014-07-08 12:38:53 +0200
commit2fd70277c17c2efff8b5a6c3fc5bd4dddc66736b (patch)
tree2646c30f48c749bbe5d5edb384e35bd7feb31464
parentb388a572c8ef9c971dbc16b89069429cc67c0928 (diff)
Findbugs: Use Integer.parseInt(string) for int values to avoid boxing and unboxing
-rw-r--r--src/jogl/classes/jogamp/opengl/android/av/AndroidGLMediaPlayerAPI14.java2
-rw-r--r--src/jogl/classes/jogamp/opengl/util/av/GLMediaPlayerImpl.java2
-rw-r--r--src/jogl/classes/jogamp/opengl/x11/glx/GLXUtil.java8
3 files changed, 6 insertions, 6 deletions
diff --git a/src/jogl/classes/jogamp/opengl/android/av/AndroidGLMediaPlayerAPI14.java b/src/jogl/classes/jogamp/opengl/android/av/AndroidGLMediaPlayerAPI14.java
index ea23b5239..24b89cd02 100644
--- a/src/jogl/classes/jogamp/opengl/android/av/AndroidGLMediaPlayerAPI14.java
+++ b/src/jogl/classes/jogamp/opengl/android/av/AndroidGLMediaPlayerAPI14.java
@@ -263,7 +263,7 @@ public class AndroidGLMediaPlayerAPI14 extends GLMediaPlayerImpl {
} else {
int cameraId = 0;
try {
- cameraId = Integer.valueOf(cameraPath);
+ cameraId = Integer.parseInt(cameraPath);
} catch (final NumberFormatException nfe) {}
if( 0 <= cameraId && cameraId < Camera.getNumberOfCameras() ) {
cam = Camera.open(cameraId);
diff --git a/src/jogl/classes/jogamp/opengl/util/av/GLMediaPlayerImpl.java b/src/jogl/classes/jogamp/opengl/util/av/GLMediaPlayerImpl.java
index e5369e108..6aa753ac1 100644
--- a/src/jogl/classes/jogamp/opengl/util/av/GLMediaPlayerImpl.java
+++ b/src/jogl/classes/jogamp/opengl/util/av/GLMediaPlayerImpl.java
@@ -1623,7 +1623,7 @@ public abstract class GLMediaPlayerImpl implements GLMediaPlayer {
protected static final int getPropIntVal(final Map<String, String> props, final String key) {
final String val = props.get(key);
try {
- return Integer.valueOf(val).intValue();
+ return Integer.parseInt(val);
} catch (final NumberFormatException nfe) {
if(DEBUG) {
System.err.println("Not a valid integer for <"+key+">: <"+val+">");
diff --git a/src/jogl/classes/jogamp/opengl/x11/glx/GLXUtil.java b/src/jogl/classes/jogamp/opengl/x11/glx/GLXUtil.java
index e32177b3d..195096110 100644
--- a/src/jogl/classes/jogamp/opengl/x11/glx/GLXUtil.java
+++ b/src/jogl/classes/jogamp/opengl/x11/glx/GLXUtil.java
@@ -105,8 +105,8 @@ public class GLXUtil {
final String str = GLX.glXGetClientString(x11Device.getHandle(), GLX.GLX_VERSION);
try {
// e.g. "1.3"
- major.put(0, Integer.valueOf(str.substring(0, 1)).intValue());
- minor.put(0, Integer.valueOf(str.substring(2, 3)).intValue());
+ major.put(0, Integer.parseInt(str.substring(0, 1)));
+ minor.put(0, Integer.parseInt(str.substring(2, 3)));
} catch (final Exception e) {
major.put(0, 1);
minor.put(0, 2);
@@ -161,8 +161,8 @@ public class GLXUtil {
final String str = GLX.glXGetClientString(x11Device.getHandle(), GLX.GLX_VERSION);
try {
// e.g. "1.3"
- major[0] = Integer.valueOf(str.substring(0, 1)).intValue();
- minor[0] = Integer.valueOf(str.substring(2, 3)).intValue();
+ major[0] = Integer.parseInt(str.substring(0, 1));
+ minor[0] = Integer.parseInt(str.substring(2, 3));
} catch (final Exception e) {
major[0] = 1;
minor[0] = 2;