diff options
| author | Sven Gothel <[email protected]> | 2019-09-05 05:38:25 +0200 |
|---|---|---|
| committer | Sven Gothel <[email protected]> | 2019-09-05 05:38:25 +0200 |
| commit | 90760ac8eebe7431ac7392e4ebf3f9009e63cd72 (patch) | |
| tree | 6e903a56a3fc168e9c682e787fbd3cc239c990e1 /make/stub_includes | |
| parent | b90fcb88cf208dad27402256e4f08659b17ba567 (diff) | |
Bug 1390: Fix GLPixelBuffer.GLPixelAttributes::convert(GL, int, boolean) failure on unsupported GL data format/type
GLPixelBuffer.GLPixelAttributes::convert(GL, int, boolean) failed on unsupported GL data format/type
On Mesa/AMD for GLPBuffer chosen GLCaps used rgba 10/10/10/2
and the GLContext set default values:
GL_IMPLEMENTATION_COLOR_READ_FORMAT: 0x1908 GL_RGBA
GL_IMPLEMENTATION_COLOR_READ_TYPE: 0x8368 GL_UNSIGNED_INT_2_10_10_10_REV
GLPixelBuffer.GLPixelAttributes::getPixelFormat(int format, int type)
currently does not handle the type GL_UNSIGNED_INT_2_10_10_10_REV
and hence returned a null PixelFormat.
Therefor the ctor GLPixelAttributes failed and threw the exception:
"Caught GLException: Could not find PixelFormat for format and/or type:
PixelAttributes[fmt 0x1908, type 0x8368, null]"
This fix has the GLContext default values pre-validated in the convert(..) method
and to use default GL_RGBA and GL_UNSIGNED_BYTE fallback values if not supported.
This is most important to be future proof.
Later we may shall add these 32bit coding 2+10+10+10 and its reverse.
Diffstat (limited to 'make/stub_includes')
0 files changed, 0 insertions, 0 deletions