diff options
author | Sven Gothel <[email protected]> | 2014-07-08 21:13:15 +0200 |
---|---|---|
committer | Sven Gothel <[email protected]> | 2014-07-08 21:13:15 +0200 |
commit | 815776c5760e42c8b3c858a9bab982b203c59c24 (patch) | |
tree | 3f8ecd7e905b0f431f5472565fce837b24f922ab /src/jogl/classes/com/jogamp/gluegen/opengl | |
parent | a41db57df54863566b0e286cd100bbbc5518eb7f (diff) |
Findbugs: Remove branches where reference cannot be null
Diffstat (limited to 'src/jogl/classes/com/jogamp/gluegen/opengl')
-rw-r--r-- | src/jogl/classes/com/jogamp/gluegen/opengl/BuildComposablePipeline.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/jogl/classes/com/jogamp/gluegen/opengl/BuildComposablePipeline.java b/src/jogl/classes/com/jogamp/gluegen/opengl/BuildComposablePipeline.java index f082f358f..af7694ce1 100644 --- a/src/jogl/classes/com/jogamp/gluegen/opengl/BuildComposablePipeline.java +++ b/src/jogl/classes/com/jogamp/gluegen/opengl/BuildComposablePipeline.java @@ -186,8 +186,10 @@ public class BuildComposablePipeline { } try { + // Keep assignment w/ null comparison for clarification. + // If no exception is thrown, return value is always non-null; hasImmediateMode = - (classToComposeAround.getMethod("glBegin", new Class<?>[]{Integer.TYPE}) != null); + null != classToComposeAround.getMethod("glBegin", new Class<?>[]{Integer.TYPE}); } catch (final Exception e) { } @@ -388,7 +390,7 @@ public class BuildComposablePipeline { } } - if (null != baseInterfaceClass && !clazzList.contains(baseInterfaceClass)) { + if ( !clazzList.contains(baseInterfaceClass) ) { ifNames[i++] = baseInterfaceClass.getName(); clazzList.add(baseInterfaceClass); } |