diff options
| author | Sven Gothel <[email protected]> | 2014-08-30 00:21:00 +0200 |
|---|---|---|
| committer | Sven Gothel <[email protected]> | 2014-08-30 00:21:00 +0200 |
| commit | 11347ad39059836f3e2a4f1fc592dc1e3fab6a09 (patch) | |
| tree | df73acd41f7d0d8ae932cbd594336c98d388a113 /src/jogl/classes/com/jogamp/opengl | |
| parent | dfb9ed47ac6d8e85f6ae5fe166e7a6e28ca8ff83 (diff) | |
Bug 1054: GLContext: makeCurrent() needs a null-check of [mutable] drawable; Review null checks and synchronization/locking.
'drawable' field of GLContextImpl is mutable via setGLDrawable(..),
which requires high-level locking as documented.
The required high-level locking allows us to _not_ add special
synchronization to this field (and drawableRead).
A simple null-check in makeCurrent() shall be sufficient,
plus ensuring mentioned high-level locking is applied.
GLContextImpl 'drawable' and 'drawableRead' synchronization:
- commit ad79bd072b600a3f2416cc6f0c61e2925000069d check of null drawable is sufficient
- Add GLAutoDrawable upstream-lock locking to:
- AWT GLCanvas setupPrint/releasePrint
- AWT GLJPanel (was missing)
Misc:
- validate shared-context native-surface locking, throw exception if not successful
- pixelDataEvaluated does not need to be synchronized, since it's being called while context is current, locking
- GLDrawableHelper.recreateGLDrawable(..): Remove redundant glFinish() call
Diffstat (limited to 'src/jogl/classes/com/jogamp/opengl')
0 files changed, 0 insertions, 0 deletions