Fix Bug 705 - Cleanup & Generalize Commit 5b47372590ec715647ebbd75d70c41ec7a64485a ; Close X11 Display in isDeviceSupported()

- Moved GL vendor version parsing to GLVersionNumber

- Moved X11Util.markAllDisplaysUnclosable() trigger into SharedResource creation of
  - X11GLXDrawableFactory
  - EGLDrawableFactory

- GLProfile is back to pre 5b47372590ec715647ebbd75d70c41ec7a64485a,
  i.e. contains no quirk artifact (clean)

- Close X11 Display in X11GLXDrawableFactory.isDeviceSupported()
  Regression of 9a4fcc7ea4ec61e4ceed791acced734ac04ea270

- TODO: Remove X11Util markAllDisplaysUnclosable detection code ?

Notes to Martin:
  - Use TAB == 4 SPACES
  - No author names into source code, git commit log is enough.
  - No need to tag your edits, the diff is enough.

1 files changed, 0 insertions, 25 deletions

diff --git a/src/jogl/classes/javax/media/opengl/GLProfile.java b/src/jogl/classes/javax/media/opengl/GLProfile.java
index 54ed479a9..1b6af22d4 100644
--- a/src/jogl/classes/javax/media/opengl/GLProfile.java
+++ b/src/jogl/classes/javax/media/opengl/GLProfile.java
@@ -64,11 +64,6 @@ import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 
-// Added to check if X11 Displays should be closed on exit
-// Martin C. Hegedus, March 30, 2013
-import com.jogamp.opengl.GLRendererQuirks;
-import jogamp.nativewindow.x11.X11Util;
-
 /**
  * Specifies the the OpenGL profile.
  * 
@@ -1530,26 +1525,6 @@ public class GLProfile {
         final boolean addedDesktopProfile = null != defaultDesktopDevice ? initProfilesForDevice(defaultDesktopDevice) : false;        
         final boolean addedAnyProfile     = addedEGLProfile || addedDesktopProfile ;
     
-	// Added to check if X11 Displays should be closed on exit
-	// NOTE:  This checks defaultEGLDevice and defaultDesktopDevice to determine if XCloseDisplay should be called on exit
-	// NOTE:  These checks must be done after initProfilesForDevice since GLContext must set up the renderer quirks.
-	// NOTE:  At this point the shared resource has already opened a display, created a new context, made it current, and
-	//        released it.  Let's cross our fingers that at this point in the code the context will not be destroyed and 
-	//        the display closed under any circumstances.
-	// NOTE:  The checks can be tricked if the default screen is using a driver other than X11 and later a X11 Display,
-	//        such as a remote display, is opened.  If this occurs then markAllDisplaysUnclosable will not have been
-	//        correctly set.  Something to deal with at a later date.
-	//
-	// Martin C. Hegedus, March 30, 2013
-	if (eglFactory != null && defaultEGLDevice != null &&
-	    eglFactory.hasRendererQuirk(defaultEGLDevice,GLRendererQuirks.DontCloseX11DisplayConnection) &&
-	    NativeWindowFactory.getNativeWindowType(true) == NativeWindowFactory.TYPE_X11)
-	    X11Util.markAllDisplaysUnclosable();
-	if (desktopFactory != null && defaultDesktopDevice != null &&
-	    desktopFactory.hasRendererQuirk(defaultDesktopDevice,GLRendererQuirks.DontCloseX11DisplayConnection) &&
-	    NativeWindowFactory.getNativeWindowType(true) == NativeWindowFactory.TYPE_X11)
-	    X11Util.markAllDisplaysUnclosable();
-            
         if(DEBUG) {
             System.err.println("GLProfile.init addedAnyProfile       "+addedAnyProfile+" (desktop: "+addedDesktopProfile+", egl "+addedEGLProfile+")");
             System.err.println("GLProfile.init isAWTAvailable        "+isAWTAvailable);