diff options
| author | Sven Gothel <[email protected]> | 2023-04-19 20:56:34 +0200 |
|---|---|---|
| committer | Sven Gothel <[email protected]> | 2023-04-19 20:56:34 +0200 |
| commit | 736d7a18f3e25744a31f85acedbd5b417f073afe (patch) | |
| tree | de86645970175b46ec4e42d9f126168e9483c17a /src/jogl/classes/jogamp/graph/curve/opengl | |
| parent | 920efa82bf88a30b1180687955b175fc9c3abc1d (diff) | |
Graph VBORegion2P*.renderVBO(): Add comment on BITHINT_GLOBAL_DEPTH_TEST_ENABLED usage -> To be investigated.
Diffstat (limited to 'src/jogl/classes/jogamp/graph/curve/opengl')
| -rw-r--r-- | src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PMSAAES2.java | 4 | ||||
| -rw-r--r-- | src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PVBAAES2.java | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PMSAAES2.java b/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PMSAAES2.java index a6401fbd7..2ccb0b050 100644 --- a/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PMSAAES2.java +++ b/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PMSAAES2.java @@ -365,6 +365,10 @@ public final class VBORegion2PMSAAES2 extends GLRegion { gl.glViewport(0, 0, width, height); if( rs.isHintMaskSet(RenderState.BITHINT_BLENDING_ENABLED | RenderState.BITHINT_GLOBAL_DEPTH_TEST_ENABLED) ) { + // BITHINT_GLOBAL_DEPTH_TEST_ENABLED path added by commit 45395696c252c215a8a22d05e5da7e98c662d07e (2014-04-10), + // but not in VBORegion2PVBAA.renderVBO(..) -> investigate if required for working MSAA: + // - "VBORegion2PMSAAES2 enables/disables GL_DEPTH_TEST, otherwise MSAA is corrupt" + // // RGB is already multiplied w/ alpha via renderRegion2FBO(..) gl.glBlendFunc(GL.GL_ONE, GL.GL_ONE_MINUS_SRC_ALPHA); gl.glEnable(GL.GL_DEPTH_TEST); diff --git a/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PVBAAES2.java b/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PVBAAES2.java index 49c91ce4b..ac7ec21fc 100644 --- a/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PVBAAES2.java +++ b/src/jogl/classes/jogamp/graph/curve/opengl/VBORegion2PVBAAES2.java @@ -475,6 +475,11 @@ public final class VBORegion2PVBAAES2 extends GLRegion { final int vpWidth, final int vpHeight, final int sampleCount) { gl.glViewport(0, 0, vpWidth, vpHeight); + // Specific BITHINT_GLOBAL_DEPTH_TEST_ENABLED path added to + // VBORegion2PMSAA.renderVBO(..) by commit 45395696c252c215a8a22d05e5da7e98c662d07e (2014-04-10), + // but not here -> investigate if required for working MSAA: + // - "VBORegion2PMSAAES2 enables/disables GL_DEPTH_TEST, otherwise MSAA is corrupt" + // if( rs.isHintMaskSet(RenderState.BITHINT_BLENDING_ENABLED) ) { // RGB is already multiplied w/ alpha via renderRegion2FBO(..) gl.glBlendFunc(GL.GL_ONE, GL.GL_ONE_MINUS_SRC_ALPHA); |