Security: Apply security changes from GlueGen

GlueGen related commits
  - 23341a2df2d2ea36784a16fa1db8bc7385351a12
  - 2d8e25398e929f553c4524e9c57f083d90ba4e08
  - 8cabcd2de8b46c42dffcaaf46ccc2dc4d092ebba
  - f69831574d4927d03d40c330d0b047d8c89622a4
  - eb842815498f5926828b49c48fffce22fc9586a2

1 files changed, 37 insertions, 17 deletions

diff --git a/src/jogl/classes/jogamp/opengl/GLContextImpl.java b/src/jogl/classes/jogamp/opengl/GLContextImpl.java
index cab629c3a..4ab051028 100644
--- a/src/jogl/classes/jogamp/opengl/GLContextImpl.java
+++ b/src/jogl/classes/jogamp/opengl/GLContextImpl.java
@@ -42,6 +42,8 @@ package jogamp.opengl;
 
 import java.nio.ByteBuffer;
 import java.nio.IntBuffer;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -1144,10 +1146,31 @@ public abstract class GLContextImpl extends GLContext {
 
   /** Helper routine which resets a ProcAddressTable generated by the
       GLEmitter by looking up anew all of its function pointers. */
-  protected final void resetProcAddressTable(ProcAddressTable table) {
-    table.reset(getDrawableImpl().getGLDynamicLookupHelper() );
+  protected final void resetProcAddressTable(final ProcAddressTable table) {
+    AccessController.doPrivileged(new PrivilegedAction<Object>() {
+        public Object run() {
+            table.reset(getDrawableImpl().getGLDynamicLookupHelper() );
+            return null;
+        }
+    } );
   }
-
+  
+  /**
+   * Catches IllegalArgumentException and returns 0 if functionName is n/a,
+   * otherwise the ProcAddressTable's field value. 
+   */
+  /* pp */ final long getAddressFor(final ProcAddressTable table, final String functionName) {
+    return AccessController.doPrivileged(new PrivilegedAction<Long>() {
+        public Long run() {
+            try {
+                return Long.valueOf( table.getAddressFor(functionName) );
+            } catch (IllegalArgumentException iae) { 
+                return Long.valueOf(0);
+            }
+        }
+    } ).longValue();
+  }
+  
   private final boolean initGLRendererAndGLVersionStrings()  {
     final GLDynamicLookupHelper glDynLookupHelper = getDrawableImpl().getGLDynamicLookupHelper();
     final long _glGetString = glDynLookupHelper.dynamicLookupFunction("glGetString");
@@ -1748,7 +1771,7 @@ public abstract class GLContextImpl extends GLContext {
     // Check GL 1st (cached)
     if(null!=glProcAddressTable) { // null if this context wasn't not created
         try {
-            if(0!=glProcAddressTable.getAddressFor(glFunctionName)) {
+            if( glProcAddressTable.isFunctionAvailable( glFunctionName ) ) {
                 return true;
             }
         } catch (Exception e) {}
@@ -1758,27 +1781,24 @@ public abstract class GLContextImpl extends GLContext {
     final ProcAddressTable pTable = getPlatformExtProcAddressTable();
     if(null!=pTable) {
         try {
-            if(0!=pTable.getAddressFor(glFunctionName)) {
+            if( pTable.isFunctionAvailable( glFunctionName ) ) {
                 return true;
             }
         } catch (Exception e) {}
     }
 
     // dynamic function lookup at last incl name aliasing (not cached)
-    DynamicLookupHelper dynLookup = getDrawableImpl().getGLDynamicLookupHelper();
-    String tmpBase = GLNameResolver.normalizeVEN(GLNameResolver.normalizeARB(glFunctionName, true), true);
-    long addr = 0;
+    final DynamicLookupHelper dynLookup = getDrawableImpl().getGLDynamicLookupHelper();
+    final String tmpBase = GLNameResolver.normalizeVEN(GLNameResolver.normalizeARB(glFunctionName, true), true);
+    boolean res = false;
     int  variants = GLNameResolver.getFuncNamePermutationNumber(tmpBase);
-    for(int i = 0; 0==addr && i < variants; i++) {
-        String tmp = GLNameResolver.getFuncNamePermutation(tmpBase, i);
+    for(int i = 0; !res && i < variants; i++) {
+        final String tmp = GLNameResolver.getFuncNamePermutation(tmpBase, i);
         try {
-            addr = dynLookup.dynamicLookupFunction(tmp);
+            res = dynLookup.isFunctionAvailable(tmp);
         } catch (Exception e) { }
     }
-    if(0!=addr) {
-        return true;
-    }
-    return false;
+    return res;
   }
 
   @Override
@@ -2078,8 +2098,8 @@ public abstract class GLContextImpl extends GLContext {
   }
 
   /** Internal bootstraping glGetString(GL_RENDERER) */
-  protected static native String glGetStringInt(int name, long procAddress);
+  private static native String glGetStringInt(int name, long procAddress);
   
   /** Internal bootstraping glGetIntegerv(..) for version */
-  protected static native void glGetIntegervInt(int pname, int[] params, int params_offset, long procAddress);  
+  private static native void glGetIntegervInt(int pname, int[] params, int params_offset, long procAddress);
 }