summaryrefslogtreecommitdiffstats
path: root/src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2012-10-10 17:37:38 +0200
committerSven Gothel <[email protected]>2012-10-10 17:37:38 +0200
commit8582ece7dc7f65271b3184261697a542766d9864 (patch)
treeceac339e2c0282419aa2bbc9c4ec222eca9d084e /src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java
parentfb3795504f7b05000651a9ea558dbb1b2a3b16f5 (diff)
Simplify GLArrayHandler and reduce VBO sideffects
VBO: Always unbind VBO ASAP after data transfer (glBufferData()) and assignment (glVertexPointer(..), glVertexAttribPointer()). It's a bug to leave it bound .. due to redundancy and other calls which could have change the VBO binding. Removed syncData(..), now it's only issued at enable and hence migrated into the enable method.
Diffstat (limited to 'src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java')
-rw-r--r--src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java21
1 files changed, 9 insertions, 12 deletions
diff --git a/src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java b/src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java
index 6c8e2e762..1e882e080 100644
--- a/src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java
+++ b/src/jogl/classes/jogamp/opengl/util/GLDataArrayHandler.java
@@ -53,14 +53,14 @@ public class GLDataArrayHandler implements GLArrayHandler {
throw new UnsupportedOperationException();
}
- public final void syncData(GL gl, boolean enable, Object ext) {
- if(!ad.isVBO()) {
- // makes no sense otherwise
- throw new GLException("GLDataArrayHandler can only handle VBOs.");
- }
+ public final void enableState(GL gl, boolean enable, Object ext) {
if(enable) {
+ if(!ad.isVBO()) {
+ // makes no sense otherwise
+ throw new GLException("GLDataArrayHandler can only handle VBOs.");
+ }
Buffer buffer = ad.getBuffer();
-
+
// always bind and refresh the VBO mgr,
// in case more than one gl*Pointer objects are in use
gl.glBindBuffer(ad.getVBOTarget(), ad.getVBOName());
@@ -70,13 +70,10 @@ public class GLDataArrayHandler implements GLArrayHandler {
}
ad.setVBOWritten(true);
}
- } else {
gl.glBindBuffer(ad.getVBOTarget(), 0);
- }
- }
-
- public final void enableState(GL gl, boolean enable, Object ext) {
- // no array association
+
+ }
+ // no array association
}
}