diff options
author | Sven Gothel <[email protected]> | 2014-07-08 22:10:03 +0200 |
---|---|---|
committer | Sven Gothel <[email protected]> | 2014-07-08 22:10:03 +0200 |
commit | de53d193c86a02a3cdc46c5c8758192d957d1c67 (patch) | |
tree | 8be8e36381d6f25850b887c9ff0df7e9c2279487 /src/jogl/classes/jogamp/opengl/util/glsl | |
parent | be2b608e22d9a2a3a80eb547bee6180c2ca22678 (diff) |
Findbugs: Misc minor issues (see below)
- remove duplicate code in branch
- Use Type.valueOf(primitive)
- Don't use array.toString() directly
- remove dead code
Diffstat (limited to 'src/jogl/classes/jogamp/opengl/util/glsl')
-rw-r--r-- | src/jogl/classes/jogamp/opengl/util/glsl/fixedfunc/FixedFuncPipeline.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/jogl/classes/jogamp/opengl/util/glsl/fixedfunc/FixedFuncPipeline.java b/src/jogl/classes/jogamp/opengl/util/glsl/fixedfunc/FixedFuncPipeline.java index c65ed084d..7371b0f3b 100644 --- a/src/jogl/classes/jogamp/opengl/util/glsl/fixedfunc/FixedFuncPipeline.java +++ b/src/jogl/classes/jogamp/opengl/util/glsl/fixedfunc/FixedFuncPipeline.java @@ -748,24 +748,24 @@ public class FixedFuncPipeline { if( !gl.getContext().isCPUDataSourcingAvail() ) { throw new GLException("CPU data sourcing n/a w/ "+gl.getContext()); } - if( GL.GL_POINTS != mode ) { + // if( GL.GL_POINTS != mode ) { ((GLES2)gl).glDrawElements(mode, count, type, indices); - } else { + /* } else { // FIXME GL_POINTS ! ((GLES2)gl).glDrawElements(mode, count, type, indices); - } + } */ } } public void glDrawElements(final GL2ES2 gl, final int mode, final int count, final int type, final long indices_buffer_offset) { validate(gl, true); if ( GL2GL3.GL_QUADS == mode && !gl.isGL2() ) { throw new GLException("Cannot handle indexed QUADS on !GL2 w/ VBO due to lack of CPU index access"); - } else if( GL.GL_POINTS != mode ) { - // FIXME GL_POINTS ! + } else /* if( GL.GL_POINTS != mode ) */ { gl.glDrawElements(mode, count, type, indices_buffer_offset); - } else { + } /* else { + // FIXME GL_POINTS ! gl.glDrawElements(mode, count, type, indices_buffer_offset); - } + } */ } private final int textureEnabledCount() { |