aboutsummaryrefslogtreecommitdiffstats
path: root/src/jogl
diff options
context:
space:
mode:
authorSven Gothel <[email protected]>2014-07-08 22:05:56 +0200
committerSven Gothel <[email protected]>2014-07-08 22:05:56 +0200
commitbe2b608e22d9a2a3a80eb547bee6180c2ca22678 (patch)
tree8c0b0f3b444680c8864d29aa9f3469cf6d557f96 /src/jogl
parentf37592d54f3633c0f195a10770020cbb5a732809 (diff)
Findbugs: Add comments that FB warnings are of no concern ..
Diffstat (limited to 'src/jogl')
-rw-r--r--src/jogl/classes/com/jogamp/graph/geom/SVertex.java2
-rw-r--r--src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java2
-rw-r--r--src/jogl/classes/javax/media/opengl/GLProfile.java2
-rw-r--r--src/jogl/classes/jogamp/opengl/GLContextImpl.java2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/jogl/classes/com/jogamp/graph/geom/SVertex.java b/src/jogl/classes/com/jogamp/graph/geom/SVertex.java
index 4846ff5f1..dc6982025 100644
--- a/src/jogl/classes/com/jogamp/graph/geom/SVertex.java
+++ b/src/jogl/classes/com/jogamp/graph/geom/SVertex.java
@@ -212,7 +212,7 @@ public class SVertex implements Vertex {
*/
@Override
public SVertex clone(){
- return new SVertex(this);
+ return new SVertex(this); // OK to not call super.clone(), using own copy-ctor
}
@Override
diff --git a/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java b/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
index 078b48ec2..83fceeb2f 100644
--- a/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
+++ b/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
@@ -354,7 +354,7 @@ public class GLRendererQuirks {
* otherwise false.
*/
public static boolean areSameStickyDevice(final AbstractGraphicsDevice device1, final AbstractGraphicsDevice device2) {
- return device1.getUniqueID() == device2.getUniqueID();
+ return device1.getUniqueID() == device2.getUniqueID(); // uses .intern()!
}
/**
diff --git a/src/jogl/classes/javax/media/opengl/GLProfile.java b/src/jogl/classes/javax/media/opengl/GLProfile.java
index 57367adcc..063ad3ef7 100644
--- a/src/jogl/classes/javax/media/opengl/GLProfile.java
+++ b/src/jogl/classes/javax/media/opengl/GLProfile.java
@@ -1082,7 +1082,7 @@ public class GLProfile {
if(this==o) { return true; }
if(o instanceof GLProfile) {
final GLProfile glp = (GLProfile)o;
- return getName() == glp.getName() && getImplName() == glp.getImplName() ;
+ return getName() == glp.getName() && getImplName() == glp.getImplName() ; // uses .intern()!
}
return false;
}
diff --git a/src/jogl/classes/jogamp/opengl/GLContextImpl.java b/src/jogl/classes/jogamp/opengl/GLContextImpl.java
index 832a797e2..ff4e9314f 100644
--- a/src/jogl/classes/jogamp/opengl/GLContextImpl.java
+++ b/src/jogl/classes/jogamp/opengl/GLContextImpl.java
@@ -177,7 +177,7 @@ public abstract class GLContextImpl extends GLContext {
glRendererLowerCase = glRenderer;
glVersion = glVendor;
- if ( null != boundFBOTarget ) { // <init>: boundFBOTarget is not written yet
+ if ( !isInit && null != boundFBOTarget ) { // <init>: boundFBOTarget is not written yet
boundFBOTarget[0] = 0; // draw
boundFBOTarget[1] = 0; // read
}