Bug 1249 - NEWT X11: setVisible(false) IconicState not listening to _NET_WM_STATE_HIDDEN; setVisible(true) not restoring from _NET_WM_STATE_HIDDEN

Using Gnome Shell 3.14.4-1~deb8u1 disclosed an issue w/ our newly utilized IconicState/_NET_WM_STATE_HIDDEN,
i.e. visibleChanged(false) was never received.

This is a regression of commit 2d837a7a7130702ad36b694875613fae77c7ef06,
which utilizes WM_CHANGE_STATE_IDX + IconicState for visibility
on top-level windows.

This bug consist out of _two_ isssue:

1) setVisible(false) IconicState not listening to _NET_WM_STATE_HIDDEN
  Here, we 'listen' to _NET_WM_STATE_HIDDEN when receiving ConfigureNotify
  if supported _and_ XMapWindow has been issued.
  In such case existence/non-existence of _NET_WM_STATE_HIDDEN determines visibility.
  Otherwise, we have wait for MapNotify/UnmapNotify.

  The 'XMapWindow has been issued' criteria is tracked by new field 'JavaWindow.isMapped'
  and set/cleared when we actually issue XMapWindow/XUnmapWindow!

2) setVisible(true) not restoring from _NET_WM_STATE_HIDDEN
  It has been observed that restoring IconicState/_NET_WM_STATE_HIDDEN
  via XMapWindow or even NormalState may not work reliably on WMs.
  See <https://stackoverflow.com/questions/30192347/how-to-restore-a-window-with-xlib>

  Hence we restore from this WM state via NormalState _and_ _NET_ACTIVE_WINDOW.

Both strategies seem to work well on KDE as well as on Gnome.

1 files changed, 79 insertions, 14 deletions

diff --git a/src/newt/classes/jogamp/newt/WindowImpl.java b/src/newt/classes/jogamp/newt/WindowImpl.java
index a10cd0b4e..922b75a2e 100644
--- a/src/newt/classes/jogamp/newt/WindowImpl.java
+++ b/src/newt/classes/jogamp/newt/WindowImpl.java
@@ -4557,6 +4557,12 @@ public abstract class WindowImpl implements Window, NEWTEventConsumer
     /**
      * Triggered by implementation's WM events to update the insets.
      *
+     * @param defer
+     * @param left insets, -1 ignored
+     * @param right insets, -1 ignored
+     * @param top insets, -1 ignored
+     * @param bottom insets, -1 ignored
+     *
      * @see #getInsets()
      * @see #updateInsetsImpl(Insets)
      */
@@ -4661,31 +4667,90 @@ public abstract class WindowImpl implements Window, NEWTEventConsumer
     // Accumulated actions
     //
 
-    /** Triggered by implementation's WM events to update the client-area position, size, insets and maximized flags. */
+    /**
+     * Triggered by implementation's WM events to update the client-area position, size, insets and maximized flags.
+     *
+     * @param defer
+     * @param newX
+     * @param newY
+     * @param newWidth
+     * @param newHeight
+     * @param left insets, -1 ignored
+     * @param right insets, -1 ignored
+     * @param top insets, -1 ignored
+     * @param bottom insets, -1 ignored
+     * @param focusChange -1 ignored, 0 unfocused, > 0 focused
+     * @param visibleChange -1 ignored, 0 invisible, > 0 visible
+     * @param force
+     */
     protected final void sizePosInsetsFocusVisibleChanged(final boolean defer,
                                                           final int newX, final int newY,
                                                           final int newWidth, final int newHeight,
                                                           final int left, final int right, final int top, final int bottom,
-                                                          final boolean focusGained,
-                                                          final boolean visible,
+                                                          final int focusChange,
+                                                          final int visibleChange,
                                                           final boolean force) {
         sizeChanged(defer, newWidth, newHeight, force);
         positionChanged(defer, newX, newY);
         insetsChanged(defer, left, right, top, bottom);
-        focusChanged(defer, focusGained);
-        visibleChanged(defer, visible);
-    }
-    /** Triggered by implementation's WM events to update the client-area position, size, insets and maximized flags. */
-    protected final void sizePosMaxInsetsChanged(final boolean defer,
-                                                 final int newX, final int newY,
-                                                 final int newWidth, final int newHeight,
-                                                 final boolean newMaxHorz, final boolean newMaxVert,
-                                                 final int left, final int right, final int top, final int bottom,
-                                                 final boolean force) {
+        if( 0 <= focusChange ) { // ignore focus < 0
+            focusChanged(defer, 0 < focusChange);
+        }
+        if( 0 <= visibleChange ) { // ignore visible < 0
+            visibleChanged(defer, 0 < visibleChange);
+        }
+    }
+    /**
+     * Triggered by implementation's WM events to update the client-area position, size, insets and maximized flags.
+     *
+     * @param defer
+     * @param left insets, -1 ignored
+     * @param right insets, -1 ignored
+     * @param top insets, -1 ignored
+     * @param bottom insets, -1 ignored
+     * @param visibleChange -1 ignored, 0 invisible, > 0 visible
+     */
+    protected final void insetsVisibleChanged(final boolean defer,
+                                              final int left, final int right, final int top, final int bottom,
+                                              final int visibleChange) {
+        insetsChanged(defer, left, right, top, bottom);
+        if( 0 <= visibleChange ) { // ignore visible < 0
+            visibleChanged(defer, 0 < visibleChange);
+        }
+    }
+    /**
+     * Triggered by implementation's WM events to update the client-area position, size, insets and maximized flags.
+     *
+     * @param defer
+     * @param newX
+     * @param newY
+     * @param newWidth
+     * @param newHeight
+     * @param maxHorzChange -1 ignored, 0 !maximized, > 0 maximized
+     * @param maxVertChange -1 ignored, 0 !maximized, > 0 maximized
+     * @param left insets, -1 ignored
+     * @param right insets, -1 ignored
+     * @param top insets, -1 ignored
+     * @param bottom insets, -1 ignored
+     * @param visibleChange -1 ignored, 0 invisible, > 0 visible
+     * @param force
+     */
+    protected final void sizePosMaxInsetsVisibleChanged(final boolean defer,
+                                                        final int newX, final int newY,
+                                                        final int newWidth, final int newHeight,
+                                                        final int maxHorzChange, final int maxVertChange,
+                                                        final int left, final int right, final int top, final int bottom,
+                                                        final int visibleChange,
+                                                        final boolean force) {
         sizeChanged(defer, newWidth, newHeight, force);
         positionChanged(defer, newX, newY);
-        maximizedChanged(newMaxHorz, newMaxVert);
+        if( 0 <= maxHorzChange && 0 <= maxVertChange ) {
+            maximizedChanged(0 < maxHorzChange, 0 < maxVertChange);
+        }
         insetsChanged(defer, left, right, top, bottom);
+        if( 0 <= visibleChange ) { // ignore visible < 0
+            visibleChanged(defer, 0 < visibleChange);
+        }
     }
     /** Triggered by implementation. */
     protected final void sendMouseEventRequestFocus(final short eventType, final int modifiers,