NEWT/OSX: Cleanup 'javaWindowObject' @ window-close & avoid NPE; Disable lostFocus (resignKeyWindow) when in fullscreen mode; Ignore invalid key release/type events.

- Cleanup 'javaWindowObject' @ window-close & avoid NPE
  Ensure that the direct window.close() impl. removes the global reference
  and that all use cases check for NULL pointer.

- Disable lostFocus (resignKeyWindow) when in fullscreen mode
  Similar to the X11 KDE bug, OS X delivers a lostFocus event
  which we prevent from being processed in fullscreen mode.

- Ignore invalid key release/type events

  In case of offscreen/onscreen switching (fullscreen/reparenting) via destroy/create,
  the still pressed key would be send to the new window and repeat the action (key typed).
  State validation discards the double processing.

1 files changed, 15 insertions, 1 deletions

diff --git a/src/newt/native/MacWindow.m b/src/newt/native/MacWindow.m
index 5470be5ae..015295931 100644
--- a/src/newt/native/MacWindow.m
+++ b/src/newt/native/MacWindow.m
@@ -578,7 +578,8 @@ JNIEXPORT jlong JNICALL Java_jogamp_newt_driver_macosx_MacWindow_createWindow0
                                                styleMask: (NSUInteger) styleMask
                                                backing: (NSBackingStoreType) bufferingType
                                                defer: NO
-                                               screen: myScreen];
+                                               screen: myScreen
+                                               isFullscreenWindow: fullscreen];
     [myWindow setReleasedWhenClosed: YES]; // default
     [myWindow setPreservesContentDuringLiveResize: NO];
 
@@ -698,6 +699,19 @@ JNIEXPORT void JNICALL Java_jogamp_newt_driver_macosx_MacWindow_close0
     DBG_PRINT( "windowClose.0 - %p,%d view %p,%d, parent %p\n", 
         mWin, getRetainCount(mWin), mView, getRetainCount(mView), pWin);
 
+    if(NULL!=mView) {
+        jobject javaWindowObject = [mView getJavaWindowObject];
+        if( false == [mView getDestroyNotifySent] ) {
+            [mView setDestroyNotifySent: true];
+        } else if(NULL!=javaWindowObject) {
+            DBG_PRINT( "windowClose.Error: javaWindowObject not NULL (%p), destroyNotifySent==true\n", javaWindowObject);
+        }
+        if(NULL!=javaWindowObject) {
+            (*env)->DeleteGlobalRef(env, javaWindowObject);
+            [mView setJavaWindowObject: NULL];
+        }
+    }
+
 NS_DURING
     if(NULL!=mView) {
         // Available >= 10.5 - Makes the menubar disapear