diff options
author | Sven Gothel <[email protected]> | 2012-01-16 22:17:00 +0100 |
---|---|---|
committer | Sven Gothel <[email protected]> | 2012-01-16 22:17:00 +0100 |
commit | 7c83b3d24dc376c9b3566f3d774c7ac4c7f1cb5a (patch) | |
tree | 56a2a50b9ee3440ec89576467fa98c7ac41da918 /src/newt/native/X11Window.c | |
parent | 73d6ec97e65743b49770cf13709082c80b77b935 (diff) |
NEWTWindow Focus: Skip requestFocus() if already owning focus; setFullscreen() requests focus 'later'.
We shall rely on the focus state, hence we can skip 'requestFocus()'
if we already own the focus. This allows a fast-path especially when called
from native code (mouse click).
Request focus 'later' on setFullscreen() allowing native WM to complete event handling,
this is required especially on X11 to guarantee a focused fullscreen window.
Diffstat (limited to 'src/newt/native/X11Window.c')
-rw-r--r-- | src/newt/native/X11Window.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/newt/native/X11Window.c b/src/newt/native/X11Window.c index 0a7e1cf77..8cc9952d6 100644 --- a/src/newt/native/X11Window.c +++ b/src/newt/native/X11Window.c @@ -263,7 +263,7 @@ static void NewtWindows_requestFocus (JNIEnv *env, jobject window, Display *dpy, // Avoid 'BadMatch' errors from XSetInputFocus, ie if window is not viewable XGetWindowAttributes(dpy, w, &xwa); if(xwa.map_state == IsViewable) { - DBG_PRINT( "X11: XSetInputFocus dpy %p,win %pd\n", dpy, (void*)w); + DBG_PRINT( "X11: XSetInputFocus dpy %p,win %p\n", dpy, (void*)w); XSetInputFocus(dpy, w, RevertToParent, CurrentTime); } } |