Findbugs: Use inner static class where possible

10 files changed, 11 insertions, 11 deletions

diff --git a/src/test/com/jogamp/opengl/test/junit/graph/TestRegionRendererNEWT01.java b/src/test/com/jogamp/opengl/test/junit/graph/TestRegionRendererNEWT01.java
index 23b39926d..8e647c3ab 100644
--- a/src/test/com/jogamp/opengl/test/junit/graph/TestRegionRendererNEWT01.java
+++ b/src/test/com/jogamp/opengl/test/junit/graph/TestRegionRendererNEWT01.java
@@ -245,7 +245,7 @@ public class TestRegionRendererNEWT01 extends UITestCase {
         destroyWindow(window);
     }
 
-    private class RegionGLListener implements GLEventListener {
+    private static class RegionGLListener implements GLEventListener {
         String winTitle;
         String name;
         GPURendererListenerBase01 impl;
diff --git a/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT00.java b/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT00.java
index cc9762fe8..3a561eda4 100644
--- a/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT00.java
+++ b/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT00.java
@@ -263,7 +263,7 @@ public class TestTextRendererNEWT00 extends UITestCase {
         "in lorem. Maecenas in ipsum ac justo scelerisque sollicitudin. Quisque sit amet neque lorem,\n" +
         "-------Press H to change text---------\n";
 
-    private final class TextRendererGLEL extends TextRendererGLELBase {
+    private static final class TextRendererGLEL extends TextRendererGLELBase {
         private final GLReadBufferUtil screenshot;
         private final GLRegion regionFPS, regionFPSAnim;
         final Font font;
diff --git a/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT01.java b/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT01.java
index a96c1e926..26fc2e07c 100644
--- a/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT01.java
+++ b/src/test/com/jogamp/opengl/test/junit/graph/TestTextRendererNEWT01.java
@@ -205,7 +205,7 @@ public class TestTextRendererNEWT01 extends UITestCase {
         destroyWindow(window);
     }
 
-    private class TextGLListener extends GPUTextRendererListenerBase01 {
+    private static class TextGLListener extends GPUTextRendererListenerBase01 {
         String winTitle;
 
         public TextGLListener(final RenderState rs, final int type, final boolean debug, final boolean trace) {
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/acore/InitConcurrentBaseNEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/acore/InitConcurrentBaseNEWT.java
index 505e9a748..eb9203b75 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/acore/InitConcurrentBaseNEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/acore/InitConcurrentBaseNEWT.java
@@ -79,7 +79,7 @@ public abstract class InitConcurrentBaseNEWT extends UITestCase {
         dummyWindow.destroy();
     }
 
-    public class JOGLTask implements Runnable {
+    public static class JOGLTask implements Runnable {
         private final int id;
         private final Object postSync;
         private final boolean reuse;
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLContextSurfaceLockNEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLContextSurfaceLockNEWT.java
index 1fc8372c8..b64707350 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLContextSurfaceLockNEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLContextSurfaceLockNEWT.java
@@ -152,7 +152,7 @@ public class TestGLContextSurfaceLockNEWT extends UITestCase {
         return true;
     }
 
-    protected class MyEventCounter implements GLEventListener {
+    protected static class MyEventCounter implements GLEventListener {
         AtomicInteger reshapeCount = new AtomicInteger(0);
         AtomicInteger displayCount = new AtomicInteger(0);
 
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug00NEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug00NEWT.java
index 26a69d463..50beb8ab9 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug00NEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug00NEWT.java
@@ -58,7 +58,7 @@ public class TestGLDebug00NEWT extends UITestCase {
     static String dbgTstMsg0 = "Hello World";
     static int dbgTstId0 = 42;
 
-    public class WindowContext {
+    public static class WindowContext {
         public final Window window;
         public final GLContext context;
 
@@ -190,7 +190,7 @@ public class TestGLDebug00NEWT extends UITestCase {
         org.junit.runner.JUnitCore.main(tstname);
     }
 
-    public class MyGLDebugListener implements GLDebugListener {
+    public static class MyGLDebugListener implements GLDebugListener {
         int recSource;
         int recType;
         int recSeverity;
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug01NEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug01NEWT.java
index 67588a0d0..742804092 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug01NEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLDebug01NEWT.java
@@ -150,7 +150,7 @@ public class TestGLDebug01NEWT extends UITestCase {
         org.junit.runner.JUnitCore.main(tstname);
     }
 
-    public class MyGLDebugListener implements GLDebugListener {
+    public static class MyGLDebugListener implements GLDebugListener {
         int recSource;
         int recType;
         int recSeverity;
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLMesaBug651NEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLMesaBug651NEWT.java
index 6359b87f8..5ef025460 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLMesaBug651NEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/acore/TestGLMesaBug651NEWT.java
@@ -74,7 +74,7 @@ public class TestGLMesaBug651NEWT extends UITestCase {
     public static void releaseClass() {
     }
 
-    class UnitTester implements GLEventListener {
+    static class UnitTester implements GLEventListener {
         @Override
         public void init(final GLAutoDrawable drawable) {
             final GL gl = drawable.getGL();
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/awt/TestGLCanvasAWTActionDeadlock02AWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/awt/TestGLCanvasAWTActionDeadlock02AWT.java
index f69bbd319..596ada665 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/awt/TestGLCanvasAWTActionDeadlock02AWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/awt/TestGLCanvasAWTActionDeadlock02AWT.java
@@ -545,7 +545,7 @@ public class TestGLCanvasAWTActionDeadlock02AWT extends UITestCase {
       /** An Animator subclass which renders one frame at the time
        *  upon calls to the requestRender() method.
        **/
-      public class CustomAnimator extends AnimatorBase {
+      public static class CustomAnimator extends AnimatorBase {
           private Timer timer = null;
           private TimerTask task = null;
           private volatile boolean shouldRun;
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/glsl/TestTransformFeedbackVaryingsBug407NEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/glsl/TestTransformFeedbackVaryingsBug407NEWT.java
index 03e03fce8..71b2d488e 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/glsl/TestTransformFeedbackVaryingsBug407NEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/glsl/TestTransformFeedbackVaryingsBug407NEWT.java
@@ -41,7 +41,7 @@ public class TestTransformFeedbackVaryingsBug407NEWT extends UITestCase {
                 + "  Position = vec4(1.0, 1.0, 1.0, 1.0); \n"
                 + "}                                      \n";
 
-    class MyShader {
+    static class MyShader {
         int shaderProgram;
         int vertShader;