From 8c0f65869a4689d5f908249de3a3439930f2886e Mon Sep 17 00:00:00 2001 From: Sven Gothel Date: Tue, 23 May 2023 02:15:00 +0200 Subject: GraphUI Scene: Drop redundant and wrong setupMatrix(pmv) for forOne(..) and forAll(..), should be setup before call by user --- src/graphui/classes/com/jogamp/graph/ui/Scene.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/graphui/classes/com/jogamp/graph/ui/Scene.java b/src/graphui/classes/com/jogamp/graph/ui/Scene.java index 4ddcc719c..c501b8eb8 100644 --- a/src/graphui/classes/com/jogamp/graph/ui/Scene.java +++ b/src/graphui/classes/com/jogamp/graph/ui/Scene.java @@ -631,26 +631,24 @@ public final class Scene implements Container, GLEventListener { /** * Traverses through the graph up until {@code shape} and apply {@code action} on it. - * @param pmv + * @param pmv {@link PMVMatrix}, which shall be properly initialized, e.g. via {@link Scene#setupMatrix(PMVMatrix)} * @param shape * @param action * @return true to signal operation complete, i.e. {@code shape} found, otherwise false */ @Override public boolean forOne(final PMVMatrix pmv, final Shape shape, final Runnable action) { - setupMatrix(pmv); return TreeTool.forOne(shapes, pmv, shape, action); } /** * Traverses through the graph and apply {@link Visitor2#visit(Shape, PMVMatrix)} for each, stop if it returns true. - * @param pmv + * @param pmv {@link PMVMatrix}, which shall be properly initialized, e.g. via {@link Scene#setupMatrix(PMVMatrix)} * @param v * @return true to signal operation complete and to stop traversal, i.e. {@link Visitor2#visit(Shape, PMVMatrix)} returned true, otherwise false */ @Override public boolean forAll(final PMVMatrix pmv, final Visitor2 v) { - setupMatrix(pmv); return TreeTool.forAll(shapes, pmv, v); } -- cgit v1.2.3