From 6b1979992a7da2573c420ce3eb22f35abcbd35b7 Mon Sep 17 00:00:00 2001 From: Sven Göthel Date: Tue, 16 Jan 2024 05:02:24 +0100 Subject: Graph/GraphUI AA-Quality + SampleCount (shader): Push params down to RegionRenderer's RenderState usually rarely set from top of user API, reducing complexity. Discussion: Alternative was to pass AA-Quality same as SampleCount from the top (e.g. GraphUI Scene), however, this convolutes the API even more. Both parameter modify the resulting shader code in pass2 rendering (only). The used 'renderMode' is still maintained within the Region, since it contains more dynamic states individual to each Region instance (color-texture, ..). This despite 'renderMode' also changes the RenderState's shader program. In the end, it really doesn't matter and is a choice of frequency - the pipeline is usually rendering from on OpenGL rendering thread sequentially. AA-Quality and SampleCount simply usually don't change that often and are set only once. --- src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java') diff --git a/src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java b/src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java index 2c733f1fc..01e9f0611 100644 --- a/src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java +++ b/src/graphui/classes/com/jogamp/graph/ui/AnimGroup.java @@ -510,7 +510,7 @@ public class AnimGroup extends Group { } ); } - /** Sets whether {@link #tick()} shall be automatic issued on {@link #draw(GL2ES2, RegionRenderer, int[])}, default is {@code true}. */ + /** Sets whether {@link #tick()} shall be automatic issued on {@link #draw(GL2ES2, RegionRenderer)}, default is {@code true}. */ public final void setTickOnDraw(final boolean v) { tickOnDraw = v; } public final boolean getTickOnDraw() { return tickOnDraw; } @@ -539,11 +539,11 @@ public class AnimGroup extends Group { public final boolean getTickPaused() { return tickPaused; } @Override - public void draw(final GL2ES2 gl, final RegionRenderer renderer, final int[] sampleCount) { + public void draw(final GL2ES2 gl, final RegionRenderer renderer) { if( tickOnDraw && !tickPaused) { tickImpl(); } - super.draw(gl, renderer, sampleCount); + super.draw(gl, renderer); } public final void resetAnimation() { @@ -575,7 +575,7 @@ public class AnimGroup extends Group { } /** - * Issues an animation tick, usually done at {@link #draw(GL2ES2, RegionRenderer, int[])}. + * Issues an animation tick, usually done at {@link #draw(GL2ES2, RegionRenderer)}. * @see #setTickOnDraw(boolean) * @see #setTickPaused(boolean) */ -- cgit v1.2.3