From 81af9b231847f695e6ba1d734209e1e532bbf922 Mon Sep 17 00:00:00 2001 From: Sven Gothel Date: Tue, 8 Jul 2014 12:39:31 +0200 Subject: Findbugs: Add FIXME comment regarding float comparison (consider using FloatUtil.isEqual(ax, bx, epsilon), FloatUtil.isZero(bx, epsilon), ..) --- src/jogl/classes/jogamp/graph/geom/plane/Crossing.java | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/jogl/classes') diff --git a/src/jogl/classes/jogamp/graph/geom/plane/Crossing.java b/src/jogl/classes/jogamp/graph/geom/plane/Crossing.java index f46dd3c94..2ae9d1867 100644 --- a/src/jogl/classes/jogamp/graph/geom/plane/Crossing.java +++ b/src/jogl/classes/jogamp/graph/geom/plane/Crossing.java @@ -190,6 +190,7 @@ public class Crossing { } // CURVE-END if (t > 1 - DELTA) { + // FIXME: consider using FloatUtil.isEqual(ax, bx, epsilon), ... if (py1 < ay && (ax != bx ? ax - bx : bx) > 0.0) { cross++; } @@ -288,6 +289,7 @@ public class Crossing { } // CURVE-START if (t < DELTA) { + // FIXME: consider using FloatUtil.isZero(bx, epsilon), ... if (py1 < 0.0 && (bx != 0.0 ? bx : (cx != bx ? cx - bx : ax - cx)) < 0.0) { cross--; } -- cgit v1.2.3