From 1c697274a3c1e976bd9c9b089d6583edf4f346ae Mon Sep 17 00:00:00 2001
From: Sven Gothel <sgothel@jausoft.com>
Date: Fri, 5 Apr 2019 05:54:48 +0200
Subject: Bug 1370: Call from Main-Thread: NW's OSXUtil.CreateNSWindow0(..) and
 NEWT's WindowDriver.createWindow0(..)

OSX 10.14.3 Mojave issues a WARNING: NSWindow drag regions should only be invalidated on the Main Thread! This will throw an exception in the future.

The complaint about NativeWindow (NW)'s OSXUtil.CreateNSWindow0(..)
might be valid, which does create a NS Window instance w/ NSView and framebuffer initialized.

However, the complaint about NEWT's WindowDriver.createWindow0(..)
is not, since the initialization incl framebuffer happened later
on the main thread.

Regardless, encapsulated both construction fully to run on the Main-Thread.

+++

Originally the Main-Thread design spec was like:
Must run on Main-Thread when or after making visible.

Oh well.
---
 .../jogamp/newt/driver/macosx/WindowDriver.java    | 43 ++++++++++++----------
 1 file changed, 23 insertions(+), 20 deletions(-)

(limited to 'src/newt')

diff --git a/src/newt/classes/jogamp/newt/driver/macosx/WindowDriver.java b/src/newt/classes/jogamp/newt/driver/macosx/WindowDriver.java
index 46c86d2c1..e6ae7719c 100644
--- a/src/newt/classes/jogamp/newt/driver/macosx/WindowDriver.java
+++ b/src/newt/classes/jogamp/newt/driver/macosx/WindowDriver.java
@@ -775,32 +775,35 @@ public class WindowDriver extends WindowImpl implements MutableSurface, DriverCl
                 }
                 windowStyle = ws;
             }
-            final long newWin = createWindow0( pS.getX(), pS.getY(), width, height,
-                                               0 != ( STATE_MASK_FULLSCREEN & flags),
-                                               windowStyle,
-                                               NSBackingStoreBuffered, surfaceHandle);
-            if ( newWin == 0 ) {
-                throw new NativeWindowException("Could not create native window "+Thread.currentThread().getName()+" "+this);
-            }
-            setWindowHandle( newWin );
-
-            final boolean isOpaque = getGraphicsConfiguration().getChosenCapabilities().isBackgroundOpaque() && !offscreenInstance;
             // Blocking initialization on main-thread!
+            final long[] newWin = { 0 };
             OSXUtil.RunOnMainThread(true, false /* kickNSApp */, new Runnable() {
                     @Override
                     public void run() {
-                        initWindow0( parentWinHandle, newWin, pS.getX(), pS.getY(), width, height, reqPixelScale[0] /* HiDPI uniformPixelScale */,
-                                     isOpaque,
-                                     !offscreenInstance && 0 != ( STATE_MASK_ALWAYSONTOP & flags),
-                                     !offscreenInstance && 0 != ( STATE_MASK_ALWAYSONBOTTOM & flags),
-                                     !offscreenInstance && 0 != ( STATE_MASK_VISIBLE & flags),
-                                     surfaceHandle);
-                        if( offscreenInstance ) {
-                            orderOut0(0!=parentWinHandle ? parentWinHandle : newWin);
-                        } else {
-                            setTitle0(newWin, getTitle());
+                        newWin[0] = createWindow0( pS.getX(), pS.getY(), width, height,
+                                                   0 != ( STATE_MASK_FULLSCREEN & flags),
+                                                   windowStyle,
+                                                   NSBackingStoreBuffered, surfaceHandle);
+                        if ( newWin[0] != 0 ) {
+                            final boolean isOpaque = getGraphicsConfiguration().getChosenCapabilities().isBackgroundOpaque() && !offscreenInstance;
+                            initWindow0( parentWinHandle, newWin[0], pS.getX(), pS.getY(), width, height, reqPixelScale[0] /* HiDPI uniformPixelScale */,
+                                         isOpaque,
+                                         !offscreenInstance && 0 != ( STATE_MASK_ALWAYSONTOP & flags),
+                                         !offscreenInstance && 0 != ( STATE_MASK_ALWAYSONBOTTOM & flags),
+                                         !offscreenInstance && 0 != ( STATE_MASK_VISIBLE & flags),
+                                         surfaceHandle);
+                            if( offscreenInstance ) {
+                                orderOut0(0!=parentWinHandle ? parentWinHandle : newWin[0]);
+                            } else {
+                                setTitle0(newWin[0], getTitle());
+                            }
                         }
                     } });
+
+            if ( newWin[0] == 0 ) {
+                throw new NativeWindowException("Could not create native window "+Thread.currentThread().getName()+" "+this);
+            }
+            setWindowHandle( newWin[0] );
         } catch (final Exception ie) {
             ie.printStackTrace();
         }
-- 
cgit v1.2.3