aboutsummaryrefslogtreecommitdiffstats
path: root/licenses
diff options
context:
space:
mode:
authorGreg <[email protected]>2016-12-12 17:54:22 -0800
committerGreg <[email protected]>2016-12-12 17:54:22 -0800
commitb801f7cad5c1600656ca9205452b01e6a8b192a4 (patch)
treef053c11bb8be905e81e5611297c9d09b6eb525a5 /licenses
parent5aa54887b7bffe4de233474e9687a63f8ae84eb7 (diff)
Fix deadlock in AudioFifo.
The deadlock scenario is the following: 1) AudioFifo is used with wait on write and read 2) Producer Thread calls write(). The buffer is full, then it gets into the while(available() == buffer.length) loop 3) a context switch happens right there, BEFORE readSemaphore.wait() 4) Consumer Thread calls read() multiple times until it depletes the buffer, then ends up in writeSemaphore.wait() 5) context switch back to the Producer Thread, which now calls readSemaphore.wait() Deadlock: the buffer is empty, and nobody is going to signal the producer that there is availability. This can be reproduced with a simple stress test. I added the stress test which is simply a copy of an existing one, with a very large value for the chunk variable. The race condition is more likely to be hit when the buffer is small, but I have hit it in "production" with 32K buffers, while generating large files (a few hundred megabytes). I am not sure the performance implications of the change, as my use cases are non-realtime. Still, all the tests pass.
Diffstat (limited to 'licenses')
0 files changed, 0 insertions, 0 deletions