summaryrefslogtreecommitdiffstats
path: root/LibOVR/Src/Kernel/OVR_Std.h
diff options
context:
space:
mode:
Diffstat (limited to 'LibOVR/Src/Kernel/OVR_Std.h')
-rw-r--r--LibOVR/Src/Kernel/OVR_Std.h266
1 files changed, 195 insertions, 71 deletions
diff --git a/LibOVR/Src/Kernel/OVR_Std.h b/LibOVR/Src/Kernel/OVR_Std.h
index c11f853..6a14231 100644
--- a/LibOVR/Src/Kernel/OVR_Std.h
+++ b/LibOVR/Src/Kernel/OVR_Std.h
@@ -1,21 +1,21 @@
/************************************************************************************
-PublicHeader: OVR.h
+PublicHeader: OVR_Kernel.h
Filename : OVR_Std.h
Content : Standard C function interface
Created : September 19, 2012
Notes :
-Copyright : Copyright 2014 Oculus VR, Inc. All Rights reserved.
+Copyright : Copyright 2014 Oculus VR, LLC All Rights reserved.
-Licensed under the Oculus VR Rift SDK License Version 3.1 (the "License");
+Licensed under the Oculus VR Rift SDK License Version 3.2 (the "License");
you may not use the Oculus VR Rift SDK except in compliance with the License,
which is provided at the time of installation or download, or which
otherwise accompanies this software in either electronic or hard copy form.
You may obtain a copy of the License at
-http://www.oculusvr.com/licenses/LICENSE-3.1
+http://www.oculusvr.com/licenses/LICENSE-3.2
Unless required by applicable law or agreed to in writing, the Oculus VR SDK
distributed under the License is distributed on an "AS IS" BASIS,
@@ -35,7 +35,7 @@ limitations under the License.
#include <stdlib.h>
#include <ctype.h>
-#if !defined(OVR_OS_WINCE) && defined(OVR_CC_MSVC) && (OVR_CC_MSVC >= 1400)
+#if defined(OVR_CC_MSVC) && (OVR_CC_MSVC >= 1400)
#define OVR_MSVC_SAFESTRING
#include <errno.h>
#endif
@@ -46,8 +46,10 @@ limitations under the License.
namespace OVR {
-#if defined(OVR_OS_WIN32)
-inline char* OVR_CDECL OVR_itoa(int val, char *dest, UPInt destsize, int radix)
+// Has the same behavior as itoa aside from also having a dest size argument.
+// Return value: Pointer to the resulting null-terminated string, same as parameter str.
+#if defined(OVR_OS_MS)
+inline char* OVR_CDECL OVR_itoa(int val, char *dest, size_t destsize, int radix)
{
#if defined(OVR_MSVC_SAFESTRING)
_itoa_s(val, dest, destsize, radix);
@@ -57,8 +59,8 @@ inline char* OVR_CDECL OVR_itoa(int val, char *dest, UPInt destsize, int radix)
return itoa(val, dest, radix);
#endif
}
-#else // OVR_OS_WIN32
-inline char* OVR_itoa(int val, char* dest, unsigned int len, int radix)
+#else // OVR_OS_MS
+inline char* OVR_itoa(int val, char* dest, size_t len, int radix)
{
if (val == 0)
{
@@ -67,12 +69,15 @@ inline char* OVR_itoa(int val, char* dest, unsigned int len, int radix)
dest[0] = '0';
dest[1] = '\0';
}
+ else if(len > 0)
+ dest[0] = '\0';
return dest;
}
+ // FIXME: Fix the following code to avoid memory write overruns when len is in sufficient.
int cur = val;
- unsigned int i = 0;
- unsigned int sign = 0;
+ size_t i = 0;
+ size_t sign = 0;
if (val < 0)
{
@@ -124,7 +129,7 @@ inline char* OVR_itoa(int val, char* dest, unsigned int len, int radix)
dest[i++] = '-';
}
- for (unsigned int j = 0; j < i / 2; ++j)
+ for (size_t j = 0; j < i / 2; ++j)
{
char tmp = dest[j];
dest[j] = dest[i - 1 - j];
@@ -140,39 +145,78 @@ inline char* OVR_itoa(int val, char* dest, unsigned int len, int radix)
// String functions
-inline UPInt OVR_CDECL OVR_strlen(const char* str)
+inline size_t OVR_CDECL OVR_strlen(const char* str)
{
return strlen(str);
}
-inline char* OVR_CDECL OVR_strcpy(char* dest, UPInt destsize, const char* src)
+inline char* OVR_CDECL OVR_strcpy(char* dest, size_t destsize, const char* src)
{
#if defined(OVR_MSVC_SAFESTRING)
strcpy_s(dest, destsize, src);
return dest;
#else
+ // FIXME: This should be a safer implementation
OVR_UNUSED(destsize);
return strcpy(dest, src);
#endif
}
-inline char* OVR_CDECL OVR_strncpy(char* dest, UPInt destsize, const char* src, UPInt count)
+
+// Acts the same as the strlcpy function.
+// Copies src to dest, 0-terminating even if it involves truncating the write.
+// Returns the required strlen of dest (which is one less than the required size of dest).
+// strlcpy is a safer alternative to strcpy and strncpy and provides size information.
+// However, it still may result in an incomplete copy.
+//
+// Example usage:
+// char buffer[256];
+// if(OVR_strlcpy(buffer, "hello world", sizeof(buffer)) < sizeof(buffer))
+// { there was enough space }
+// else
+// { need a larger buffer }
+//
+size_t OVR_CDECL OVR_strlcpy(char* dest, const char* src, size_t destsize);
+
+// Acts the same as the strlcat function.
+// Appends src to dest, 0-terminating even if it involves an incomplete write.
+// Doesn't 0-terminate in the case that destsize is 0.
+// Returns the required strlen of dest (which is one less than the required size of dest).
+// The terminating 0 char of dest is overwritten by the first
+// character of src, and a new 0 char is appended to dest. The required capacity
+// of the destination is (strlen(src) + strlen(dest) + 1).
+// strlcat is a safer alternative to strcat and provides size information.
+// However, it still may result in an incomplete copy.
+//
+// Example usage:
+// char buffer[256] = "hello ";
+// if(OVR_strlcat(buffer, "world", sizeof(buffer)) < sizeof(buffer))
+// { there was enough space }
+// else
+// { need a larger buffer }
+//
+size_t OVR_CDECL OVR_strlcat(char* dest, const char* src, size_t destsize);
+
+
+inline char* OVR_CDECL OVR_strncpy(char* dest, size_t destsize, const char* src, size_t count)
{
#if defined(OVR_MSVC_SAFESTRING)
strncpy_s(dest, destsize, src, count);
return dest;
#else
+ // FIXME: This should be a safer implementation
OVR_UNUSED(destsize);
return strncpy(dest, src, count);
#endif
}
-inline char * OVR_CDECL OVR_strcat(char* dest, UPInt destsize, const char* src)
+inline char * OVR_CDECL OVR_strcat(char* dest, size_t destsize, const char* src)
{
#if defined(OVR_MSVC_SAFESTRING)
strcat_s(dest, destsize, src);
return dest;
#else
+ // FIXME: This should be a safer implementation
OVR_UNUSED(destsize);
return strcat(dest, src);
#endif
@@ -195,16 +239,16 @@ inline char* OVR_CDECL OVR_strchr(char* str, char c)
inline const char* OVR_strrchr(const char* str, char c)
{
- UPInt len = OVR_strlen(str);
- for (UPInt i=len; i>0; i--)
+ size_t len = OVR_strlen(str);
+ for (size_t i=len; i>0; i--)
if (str[i]==c)
return str+i;
return 0;
}
-inline const UByte* OVR_CDECL OVR_memrchr(const UByte* str, UPInt size, UByte c)
+inline const uint8_t* OVR_CDECL OVR_memrchr(const uint8_t* str, size_t size, uint8_t c)
{
- for (SPInt i = (SPInt)size - 1; i >= 0; i--)
+ for (intptr_t i = (intptr_t)size - 1; i >= 0; i--)
{
if (str[i] == c)
return str + i;
@@ -214,8 +258,8 @@ inline const UByte* OVR_CDECL OVR_memrchr(const UByte* str, UPInt size, UByte c)
inline char* OVR_CDECL OVR_strrchr(char* str, char c)
{
- UPInt len = OVR_strlen(str);
- for (UPInt i=len; i>0; i--)
+ size_t len = OVR_strlen(str);
+ for (size_t i=len; i>0; i--)
if (str[i]==c)
return str+i;
return 0;
@@ -234,23 +278,23 @@ inline long OVR_CDECL OVR_strtoul(const char* string, char** tailptr, int radix)
return strtoul(string, tailptr, radix);
}
-inline int OVR_CDECL OVR_strncmp(const char* ws1, const char* ws2, UPInt size)
+inline int OVR_CDECL OVR_strncmp(const char* ws1, const char* ws2, size_t size)
{
return strncmp(ws1, ws2, size);
}
-inline UInt64 OVR_CDECL OVR_strtouq(const char *nptr, char **endptr, int base)
+inline uint64_t OVR_CDECL OVR_strtouq(const char *nptr, char **endptr, int base)
{
-#if defined(OVR_CC_MSVC) && !defined(OVR_OS_WINCE)
+#if defined(OVR_CC_MSVC)
return _strtoui64(nptr, endptr, base);
#else
return strtoull(nptr, endptr, base);
#endif
}
-inline SInt64 OVR_CDECL OVR_strtoq(const char *nptr, char **endptr, int base)
+inline int64_t OVR_CDECL OVR_strtoq(const char *nptr, char **endptr, int base)
{
-#if defined(OVR_CC_MSVC) && !defined(OVR_OS_WINCE)
+#if defined(OVR_CC_MSVC)
return _strtoi64(nptr, endptr, base);
#else
return strtoll(nptr, endptr, base);
@@ -258,30 +302,34 @@ inline SInt64 OVR_CDECL OVR_strtoq(const char *nptr, char **endptr, int base)
}
-inline SInt64 OVR_CDECL OVR_atoq(const char* string)
+inline int64_t OVR_CDECL OVR_atoq(const char* string)
{
-#if defined(OVR_CC_MSVC) && !defined(OVR_OS_WINCE)
+#if defined(OVR_CC_MSVC)
return _atoi64(string);
#else
return atoll(string);
#endif
}
-inline UInt64 OVR_CDECL OVR_atouq(const char* string)
+inline uint64_t OVR_CDECL OVR_atouq(const char* string)
{
return OVR_strtouq(string, NULL, 10);
}
-// Implemented in GStd.cpp in platform-specific manner.
+// Implemented in OVR_Std.cpp in platform-specific manner.
int OVR_CDECL OVR_stricmp(const char* dest, const char* src);
-int OVR_CDECL OVR_strnicmp(const char* dest, const char* src, UPInt count);
+int OVR_CDECL OVR_strnicmp(const char* dest, const char* src, size_t count);
+
-inline UPInt OVR_CDECL OVR_sprintf(char *dest, UPInt destsize, const char* format, ...)
+// This is like sprintf but with a destination buffer size argument. However, the behavior is different
+// from vsnprintf in that the return value semantics are like sprintf (which returns -1 on capacity overflow) and
+// not like snprintf (which returns intended strlen on capacity overflow).
+inline size_t OVR_CDECL OVR_sprintf(char *dest, size_t destsize, const char* format, ...)
{
va_list argList;
va_start(argList,format);
- UPInt ret;
+ size_t ret;
#if defined(OVR_CC_MSVC)
#if defined(OVR_MSVC_SAFESTRING)
ret = _vsnprintf_s(dest, destsize, _TRUNCATE, format, argList);
@@ -301,9 +349,16 @@ inline UPInt OVR_CDECL OVR_sprintf(char *dest, UPInt destsize, const char* forma
return ret;
}
-inline UPInt OVR_CDECL OVR_vsprintf(char *dest, UPInt destsize, const char * format, va_list argList)
+
+// This is like vsprintf but with a destination buffer size argument. However, the behavior is different
+// from vsnprintf in that the return value semantics are like vsprintf (which returns -1 on capacity overflow) and
+// not like vsnprintf (which returns intended strlen on capacity overflow).
+// Return value:
+// On success, the total number of characters written is returned.
+// On failure, a negative number is returned.
+inline size_t OVR_CDECL OVR_vsprintf(char *dest, size_t destsize, const char * format, va_list argList)
{
- UPInt ret;
+ size_t ret;
#if defined(OVR_CC_MSVC)
#if defined(OVR_MSVC_SAFESTRING)
dest[0] = '\0';
@@ -314,50 +369,119 @@ inline UPInt OVR_CDECL OVR_vsprintf(char *dest, UPInt destsize, const char * for
ret = destsize - 1;
}
else
- ret = (UPInt)rv;
+ ret = (size_t)rv;
#else
OVR_UNUSED(destsize);
int rv = _vsnprintf(dest, destsize - 1, format, argList);
OVR_ASSERT(rv != -1);
- ret = (UPInt)rv;
+ ret = (size_t)rv;
dest[destsize-1] = 0;
#endif
#else
+ // FIXME: This should be a safer implementation
OVR_UNUSED(destsize);
- ret = (UPInt)vsprintf(dest, format, argList);
+ ret = (size_t)vsprintf(dest, format, argList);
OVR_ASSERT(ret < destsize);
#endif
return ret;
}
-// Returns the number of characters in the formatted string.
-inline UPInt OVR_CDECL OVR_vscprintf(const char * format, va_list argList)
+// Same behavior as ISO C99 vsnprintf.
+// Returns the strlen of the resulting formatted string, or a negative value if the format is invalid.
+// destsize specifies the capacity of the input buffer.
+//
+// Example usage:
+// void Log(char *dest, size_t destsize, const char * format, ...)
+// {
+// char buffer[1024];
+// va_list argList;
+// va_start(argList,format);
+// int result = OVR_vsnprintf(dest, destsize, format, argList);
+// assert(result < destsize); // Else we'd have to retry with a dynamically allocated buffer (of size=result+1) and new argList copy.
+// va_end(argList);
+// }
+
+inline int OVR_CDECL OVR_vsnprintf(char *dest, size_t destsize, const char * format, va_list argList)
+{
+ int ret;
+#if defined(OVR_CC_MSVC)
+ OVR_DISABLE_MSVC_WARNING(4996) // 'vsnprintf': This function or variable may be unsafe.
+ ret = vsnprintf(dest, destsize, format, argList); // Microsoft vsnprintf is non-conforming; it returns -1 if destsize is insufficient.
+ if (ret < 0) // If there was a format error or if destsize was insufficient...
+ {
+ ret = _vscprintf(format, argList); // Get the expected dest strlen. If the return value is still -1 then there was a format error.
+
+ if (destsize) // If we can 0-terminate the output...
+ {
+ if (ret < 0)
+ dest[0] = 0;
+ else
+ dest[destsize-1] = 0;
+ }
+ }
+ // Else the string was written OK and ret is its strlen.
+ OVR_RESTORE_MSVC_WARNING()
+#else
+ ret = vsnprintf(dest, destsize, format, argList);
+#endif
+ return ret;
+}
+
+
+// Same behavior as ISO C99 snprintf.
+// Returns the strlen of the resulting formatted string, or a negative value if the format is invalid.
+// destsize specifies the capacity of the input buffer.
+//
+// Example usage:
+// char buffer[16];
+// int result = OVR_snprintf(buffer, sizeof(buffer), "%d", 37);
+// if (result >= sizeof(buffer)) // If there was insufficient capacity...
+// {
+// char* p = new char[result + 1]; // Or char* p = (char*)OVR_ALLOC(result + 1);
+// OVR_snprintf(p, (size_t)result, "%d", 37);
+// delete[] p;
+// }
+//
+inline int OVR_CDECL OVR_snprintf(char *dest, size_t destsize, const char * format, ...)
+{
+ va_list argList;
+ va_start(argList,format);
+ int ret = OVR_vsnprintf(dest, destsize, format, argList);
+ va_end(argList);
+ return ret;
+}
+
+
+// Returns the strlen of the resulting formatted string, or a negative value if the format is invalid.
+// Note: If you are planning on printing a string then it's more efficient to just use OVR_vsnprintf and
+// look at the return value and handle the uncommon case that there wasn't enough space.
+inline int OVR_CDECL OVR_vscprintf(const char * format, va_list argList)
{
- UPInt ret;
+ int ret;
#if defined(OVR_CC_MSVC)
- ret = (UPInt) _vscprintf(format, argList);
+ ret = _vscprintf(format, argList);
#else
- ret = (UPInt) vsnprintf(NULL, 0, format, argList);
+ ret = vsnprintf(NULL, 0, format, argList);
#endif
return ret;
}
-wchar_t* OVR_CDECL OVR_wcscpy(wchar_t* dest, UPInt destsize, const wchar_t* src);
-wchar_t* OVR_CDECL OVR_wcsncpy(wchar_t* dest, UPInt destsize, const wchar_t* src, UPInt count);
-wchar_t* OVR_CDECL OVR_wcscat(wchar_t* dest, UPInt destsize, const wchar_t* src);
-UPInt OVR_CDECL OVR_wcslen(const wchar_t* str);
+wchar_t* OVR_CDECL OVR_wcscpy(wchar_t* dest, size_t destsize, const wchar_t* src);
+wchar_t* OVR_CDECL OVR_wcsncpy(wchar_t* dest, size_t destsize, const wchar_t* src, size_t count);
+wchar_t* OVR_CDECL OVR_wcscat(wchar_t* dest, size_t destsize, const wchar_t* src);
+size_t OVR_CDECL OVR_wcslen(const wchar_t* str);
int OVR_CDECL OVR_wcscmp(const wchar_t* a, const wchar_t* b);
int OVR_CDECL OVR_wcsicmp(const wchar_t* a, const wchar_t* b);
inline int OVR_CDECL OVR_wcsicoll(const wchar_t* a, const wchar_t* b)
{
-#if defined(OVR_OS_WIN32)
-#if defined(OVR_CC_MSVC) && (OVR_CC_MSVC >= 1400)
- return ::_wcsicoll(a, b);
-#else
- return ::wcsicoll(a, b);
-#endif
+#if defined(OVR_OS_MS)
+ #if defined(OVR_CC_MSVC) && (OVR_CC_MSVC >= 1400)
+ return ::_wcsicoll(a, b);
+ #else
+ return ::wcsicoll(a, b);
+ #endif
#else
// not supported, use regular wcsicmp
return OVR_wcsicmp(a, b);
@@ -366,7 +490,7 @@ inline int OVR_CDECL OVR_wcsicoll(const wchar_t* a, const wchar_t* b)
inline int OVR_CDECL OVR_wcscoll(const wchar_t* a, const wchar_t* b)
{
-#if defined(OVR_OS_WIN32) || defined(OVR_OS_LINUX)
+#if defined(OVR_OS_MS) || defined(OVR_OS_LINUX)
return wcscoll(a, b);
#else
// not supported, use regular wcscmp
@@ -376,7 +500,7 @@ inline int OVR_CDECL OVR_wcscoll(const wchar_t* a, const wchar_t* b)
#ifndef OVR_NO_WCTYPE
-inline int OVR_CDECL UnicodeCharIs(const UInt16* table, wchar_t charCode)
+inline int OVR_CDECL UnicodeCharIs(const uint16_t* table, wchar_t charCode)
{
unsigned offset = table[charCode >> 8];
if (offset == 0) return 0;
@@ -384,19 +508,19 @@ inline int OVR_CDECL UnicodeCharIs(const UInt16* table, wchar_t charCode)
return (table[offset + ((charCode >> 4) & 15)] & (1 << (charCode & 15))) != 0;
}
-extern const UInt16 UnicodeAlnumBits[];
-extern const UInt16 UnicodeAlphaBits[];
-extern const UInt16 UnicodeDigitBits[];
-extern const UInt16 UnicodeSpaceBits[];
-extern const UInt16 UnicodeXDigitBits[];
+extern const uint16_t UnicodeAlnumBits[];
+extern const uint16_t UnicodeAlphaBits[];
+extern const uint16_t UnicodeDigitBits[];
+extern const uint16_t UnicodeSpaceBits[];
+extern const uint16_t UnicodeXDigitBits[];
// Uncomment if necessary
-//extern const UInt16 UnicodeCntrlBits[];
-//extern const UInt16 UnicodeGraphBits[];
-//extern const UInt16 UnicodeLowerBits[];
-//extern const UInt16 UnicodePrintBits[];
-//extern const UInt16 UnicodePunctBits[];
-//extern const UInt16 UnicodeUpperBits[];
+//extern const uint16_t UnicodeCntrlBits[];
+//extern const uint16_t UnicodeGraphBits[];
+//extern const uint16_t UnicodeLowerBits[];
+//extern const uint16_t UnicodePrintBits[];
+//extern const uint16_t UnicodePunctBits[];
+//extern const uint16_t UnicodeUpperBits[];
inline int OVR_CDECL OVR_iswalnum (wchar_t charCode) { return UnicodeCharIs(UnicodeAlnumBits, charCode); }
inline int OVR_CDECL OVR_iswalpha (wchar_t charCode) { return UnicodeCharIs(UnicodeAlphaBits, charCode); }
@@ -473,10 +597,10 @@ inline double OVR_CDECL OVR_wcstod(const wchar_t* string, wchar_t** tailptr)
OVR_UNUSED(tailptr);
char buffer[64];
char* tp = NULL;
- UPInt max = OVR_wcslen(string);
+ size_t max = OVR_wcslen(string);
if (max > 63) max = 63;
unsigned char c = 0;
- for (UPInt i=0; i < max; i++)
+ for (size_t i=0; i < max; i++)
{
c = (unsigned char)string[i];
buffer[i] = ((c) < 128 ? (char)c : '!');
@@ -494,10 +618,10 @@ inline long OVR_CDECL OVR_wcstol(const wchar_t* string, wchar_t** tailptr, int r
OVR_UNUSED(tailptr);
char buffer[64];
char* tp = NULL;
- UPInt max = OVR_wcslen(string);
+ size_t max = OVR_wcslen(string);
if (max > 63) max = 63;
unsigned char c = 0;
- for (UPInt i=0; i < max; i++)
+ for (size_t i=0; i < max; i++)
{
c = (unsigned char)string[i];
buffer[i] = ((c) < 128 ? (char)c : '!');