Implement AL_EFFECT_REVERB

 Here is a quick description of how the reverb effect works:

 +--->---+*(4)
 |       V       new sample
 +-----+---+---+    |
 |extra|ltr|ref| <- +*(1)
 +-----+---+---+
   (3,5)*|   |*(2)
         +-->|
             V
         out sample

 1) Apply master reverb gain to incoming sample and place it at the head of the
    buffer. The master reverb gainhf was already applied when the source was
    initially mixed.
 2) Copy the delayed reflection sample to an output sample and apply the
    reflection gain.
 3) Apply the late reverb gain to the late reverb sample
 4) Copy the end of the buffer, applying a decay gain and the decay hf ratio,
    and add to the late reverb.
 5) Copy the late reverb sample, adding to the output sample.

 Then the head and sampling points are shifted forward, and done again for each
 new sample. The extra buffer length is determined by the Reverb Density
 property. A value of 0 gives a length of 0.1 seconds (long, with fairly
 distinct echos) , and 1 gives 0.075 seconds (short, indistinct echos).
 The decay gain is calculated such that after a number of loops to satisfy the
 Decay Time, a sample will be 1/32768th as powerful (virtually insignificant to
 the resulting output, and only getting further reduced). It is calculated as:

 DecayGain = pow(1.0f/32768.0f, 1.0/(DecayTime/ExtraLength));

 Things to note: Reverb Diffusion is not currently handled, nor is Decay HF
 Limit. Decay HF Ratios above 1 probably give incorrect results. Also, this
 method likely sucks, but it's the best I can come up with before release. :)

2 files changed, 67 insertions, 7 deletions

diff --git a/OpenAL32/Include/alAuxEffectSlot.h b/OpenAL32/Include/alAuxEffectSlot.h
index 66b3ba20..d4cb0d11 100644
--- a/OpenAL32/Include/alAuxEffectSlot.h
+++ b/OpenAL32/Include/alAuxEffectSlot.h
@@ -21,6 +21,15 @@ typedef struct ALeffectslot
     ALfloat Gain;
     ALboolean AuxSendAuto;
 
+    ALfloat *ReverbBuffer;
+    // in frames!
+    ALuint ReverbLength;
+    ALuint ReverbPos;
+    ALuint ReverbReflectPos;
+    ALuint ReverbLatePos;
+    ALfloat ReverbDecayGain;
+    ALfloat LastDecaySample;
+
     ALuint refcount;
 
     // Index to itself
diff --git a/OpenAL32/alAuxEffectSlot.c b/OpenAL32/alAuxEffectSlot.c
index 3ce845ce..41ea6c72 100644
--- a/OpenAL32/alAuxEffectSlot.c
+++ b/OpenAL32/alAuxEffectSlot.c
@@ -21,6 +21,7 @@
 #include "config.h"
 
 #include <stdlib.h>
+#include <math.h>
 
 #include "AL/al.h"
 #include "AL/alc.h"
@@ -30,6 +31,9 @@
 #include "alError.h"
 
 
+static ALvoid InitializeEffect(ALCcontext *Context, ALeffectslot *ALEffectSlot, ALeffect *effect);
+
+
 AL_API ALvoid AL_APIENTRY alGenAuxiliaryEffectSlots(ALsizei n, ALuint *effectslots)
 {
     ALCcontext *Context;
@@ -144,6 +148,8 @@ AL_API ALvoid AL_APIENTRY alDeleteAuxiliaryEffectSlots(ALsizei n, ALuint *effect
                         *list = (*list)->next;
                     ALTHUNK_REMOVEENTRY(ALAuxiliaryEffectSlot->effectslot);
 
+                    free(ALAuxiliaryEffectSlot->ReverbBuffer);
+
                     memset(ALAuxiliaryEffectSlot, 0, sizeof(ALeffectslot));
                     free(ALAuxiliaryEffectSlot);
 
@@ -202,13 +208,7 @@ AL_API ALvoid AL_APIENTRY alAuxiliaryEffectSloti(ALuint effectslot, ALenum param
             if(alIsEffect(iValue))
             {
                 ALeffect *effect = (ALeffect*)ALTHUNK_LOOKUPENTRY(iValue);
-                if(!effect)
-                {
-                    ALEffectSlot->effect.type = AL_EFFECT_NULL;
-                    ALEffectSlot->effect.effect = 0;
-                }
-                else
-                    memcpy(&ALEffectSlot->effect, effect, sizeof(*effect));
+                InitializeEffect(Context, ALEffectSlot, effect);
             }
             else
                 alSetError(AL_INVALID_VALUE);
@@ -465,6 +465,55 @@ AL_API ALvoid AL_APIENTRY alGetAuxiliaryEffectSlotfv(ALuint effectslot, ALenum p
 }
 
 
+static ALvoid InitializeEffect(ALCcontext *Context, ALeffectslot *ALEffectSlot, ALeffect *effect)
+{
+    ALfloat *ptr = NULL;
+
+    if(!effect)
+    {
+        memset(&ALEffectSlot->effect, 0, sizeof(ALEffectSlot->effect));
+        goto done;
+    }
+
+    if(effect->type == AL_EFFECT_REVERB)
+    {
+        ALuint size;
+        ALfloat reverbwait;
+
+        reverbwait = (1.0f-effect->Reverb.Density)*(0.1f-0.075f) + 0.075f;
+
+        size = (ALuint)((ALfloat)Context->Frequency *
+                        (effect->Reverb.ReflectionsDelay +
+                         effect->Reverb.LateReverbDelay +
+                         reverbwait)) + 1;
+
+        ptr = calloc(size, sizeof(ALfloat));
+        if(!ptr)
+        {
+            alSetError(AL_OUT_OF_MEMORY);
+            return;
+        }
+        ALEffectSlot->ReverbLength = size;
+        ALEffectSlot->ReverbPos = 0;
+        ALEffectSlot->ReverbReflectPos = (ALuint)(ALEffectSlot->ReverbLength -
+                                          ((ALfloat)Context->Frequency *
+                                           effect->Reverb.ReflectionsDelay)) %
+                                         ALEffectSlot->ReverbLength;
+        ALEffectSlot->ReverbLatePos = (ALuint)(ALEffectSlot->ReverbLength -
+                                               ((ALfloat)Context->Frequency *
+                                              (effect->Reverb.LateReverbDelay +
+                                           effect->Reverb.ReflectionsDelay))) %
+                                         ALEffectSlot->ReverbLength;
+        ALEffectSlot->ReverbDecayGain = pow(1.0/32768.0, 1.0/(effect->Reverb.DecayTime/reverbwait));
+    }
+
+    memcpy(&ALEffectSlot->effect, effect, sizeof(*effect));
+done:
+    free(ALEffectSlot->ReverbBuffer);
+    ALEffectSlot->ReverbBuffer = ptr;
+}
+
+
 ALvoid ReleaseALAuxiliaryEffectSlots(ALCcontext *Context)
 {
 #ifdef _DEBUG
@@ -478,6 +527,8 @@ ALvoid ReleaseALAuxiliaryEffectSlots(ALCcontext *Context)
         Context->AuxiliaryEffectSlot = Context->AuxiliaryEffectSlot->next;
 
         // Release effectslot structure
+        free(temp->ReverbBuffer);
+
         memset(temp, 0, sizeof(ALeffectslot));
         free(temp);
     }