aboutsummaryrefslogtreecommitdiffstats
path: root/al/effects/effects.cpp
diff options
context:
space:
mode:
authorChris Robinson <[email protected]>2023-03-09 19:58:42 -0800
committerChris Robinson <[email protected]>2023-03-09 19:58:42 -0800
commit5b3c27ea587d84c2a49150b032f5d4dec5eb50b9 (patch)
tree76c8dfe3bf3a9a30d0d08ebb730bcf9fd5b5bdd4 /al/effects/effects.cpp
parent869778979787320bf254942936f7fb1e951e57ed (diff)
Store the per-version EAX effect state in the base class
This is the start of the refactoring for holding separable per-version EAX effects. Currently the effect state is stored in the effect object, which is instantiated per-type. This makes it impossible for different effects to be assigned on different EAX versions for a given effect slot (e.g. if the app sets a Chorus effect on EAX4 Slot0, it would fail to get or set the EAX1/2/3 reverb properties since it's a Chorus effect object). Seperate per-version effects will allow for switching the OpenAL effect by switching versions. This will provide an extra benefit in being able to delay OpenAL effect initialization until some EAX version has been set, avoiding an extraneous reverb and/or chorus processor for apps that only query some EAX properties but don't set anything (or which only use Slot0, leaving Slot1 with a defaulted Chorus effect running).
Diffstat (limited to 'al/effects/effects.cpp')
-rw-r--r--al/effects/effects.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/al/effects/effects.cpp b/al/effects/effects.cpp
index 7c8447e4..820f1517 100644
--- a/al/effects/effects.cpp
+++ b/al/effects/effects.cpp
@@ -13,7 +13,7 @@ EaxEffectUPtr eax_create_eax_effect(ALenum al_effect_type, int eax_version)
switch (al_effect_type)
{
case AL_EFFECT_NULL:
- return eax_create_eax_null_effect();
+ return eax_create_eax_null_effect(eax_version);
case AL_EFFECT_CHORUS:
return eax_create_eax_chorus_effect(eax_version);