diff options
author | Chris Robinson <[email protected]> | 2021-01-06 17:52:50 -0800 |
---|---|---|
committer | Chris Robinson <[email protected]> | 2021-01-06 17:52:50 -0800 |
commit | 948ae3bc7e1e8a1b29b8e78388d1479f5b7a4758 (patch) | |
tree | 799465609be509eb80eb4619b8d14d999e5dc230 /alc/hrtf.cpp | |
parent | a9ac165c39601dfe298752f6ca0c731eba7ceeb4 (diff) |
Avoid duplicating an inline template function
Diffstat (limited to 'alc/hrtf.cpp')
-rw-r--r-- | alc/hrtf.cpp | 25 |
1 files changed, 4 insertions, 21 deletions
diff --git a/alc/hrtf.cpp b/alc/hrtf.cpp index 717f467c..9457958f 100644 --- a/alc/hrtf.cpp +++ b/alc/hrtf.cpp @@ -465,11 +465,9 @@ void MirrorLeftHrirs(const al::span<const HrtfStore::Elevation> elevs, HrirArray template<typename T, size_t num_bits=sizeof(T)*8> -inline std::enable_if_t<std::is_signed<T>::value,T> -readle(std::istream &data) +inline T readle(std::istream &data) { static_assert((num_bits&7) == 0, "num_bits must be a multiple of 8"); - constexpr auto signbit = static_cast<T>(1 << (num_bits-1)); al::byte b[num_bits/8]; if(!data.read(reinterpret_cast<char*>(b), sizeof(b))) @@ -482,25 +480,10 @@ readle(std::istream &data) for(size_t i{0};i < sizeof(b);++i) ret |= al::to_integer<T>(b[i]) << (i*8); } - return (ret^signbit) - signbit; -} - -template<typename T, size_t num_bits=sizeof(T)*8> -inline std::enable_if_t<!std::is_signed<T>::value,T> -readle(std::istream &data) -{ - static_assert((num_bits&7) == 0, "num_bits must be a multiple of 8"); - - al::byte b[num_bits/8]; - if(!data.read(reinterpret_cast<char*>(b), sizeof(b))) - return static_cast<T>(EOF); - T ret{}; - if(IS_LITTLE_ENDIAN) - std::memcpy(&ret, b, sizeof(b)); - else + if /*constexpr*/(std::is_signed<T>::value) { - for(size_t i{0};i < sizeof(b);++i) - ret |= al::to_integer<T>(b[i]) << (i*8); + constexpr auto signbit = static_cast<T>(1u << (num_bits-1)); + return (ret^signbit) - signbit; } return ret; } |