clang-tidy cleanups (#800)

* clang-tidy: use bool literals

Found with modernize-use-bool-literals

Signed-off-by: Rosen Penev <[email protected]>

* clang-tidy: replace std::bind with lambdas

Found with modernize-avoid-bind

Signed-off-by: Rosen Penev <[email protected]>

* clang-tidy: use data() instead of pointer stuff

Found with readability-container-data-pointe

Signed-off-by: Rosen Penev <[email protected]>

* clang-tidy: use empty()

Found with readability-container-size-empty

Signed-off-by: Rosen Penev <[email protected]>

* clang-tidy: remove static in anon namespace

Found with readability-static-definition-in-anonymous-namespace

Signed-off-by: Rosen Penev <[email protected]>

* clang-tidy: remove const return

Found with readability-const-return-type

Signed-off-by: Rosen Penev <[email protected]>

Signed-off-by: Rosen Penev <[email protected]>

1 files changed, 1 insertions, 1 deletions

diff --git a/core/ambdec.cpp b/core/ambdec.cpp
index 52a1df05..5e2de6af 100644
--- a/core/ambdec.cpp
+++ b/core/ambdec.cpp
@@ -53,7 +53,7 @@ al::optional<std::string> make_error(size_t linenum, const char *fmt, ...)
     auto &str = ret.emplace();
 
     str.resize(256);
-    int printed{std::snprintf(&str[0], str.length(), "Line %zu: ", linenum)};
+    int printed{std::snprintf(const_cast<char*>(str.data()), str.length(), "Line %zu: ", linenum)};
     if(printed < 0) printed = 0;
     auto plen = std::min(static_cast<size_t>(printed), str.length());