aboutsummaryrefslogtreecommitdiffstats
path: root/OpenAL32/alAuxEffectSlot.c
Commit message (Collapse)AuthorAgeFilesLines
* Avoid duplicating code using a macroChris Robinson2016-12-211-5/+1
|
* Use separate macros for atomics that don't take a memory orderChris Robinson2016-12-201-11/+11
|
* Stop using almemory_order_consumeChris Robinson2016-11-171-1/+1
|
* Remove unnecessary constsChris Robinson2016-08-311-4/+4
| | | | They were causing GCC's built-in atomic cmpxchg to complain.
* Avoid directly replacing the effect slot Update pointerChris Robinson2016-08-251-14/+10
|
* Properly defer effect slot changesChris Robinson2016-08-251-11/+28
| | | | | | | | Note that this now also causes all playing sources to update when an effect slot is updated. This is a bit wasteful, as it should only need to re-update sources that are using the effect slot (and only when a relevant property is changed), but it's good enough. Especially with deferring since all playing sources are going to get updated on the process call anyway.
* Track all references for effect statesChris Robinson2016-08-251-21/+47
| | | | | | | | This allows us to not have to play around with trying to avoid duplicate state pointers, since the reference count will ensure they're deleted as appropriate. The only caveat is that the mixer is not allowed to decrement references, since that can cause the object to be freed (which the mixer code is not allowed to do).
* Add a ref count to ALeffectStateChris Robinson2016-08-251-0/+8
| | | | | This is mostly just reorganizing the effects to call the Construct method which initializes the ref count.
* Avoid resupplying unneeded source updatesChris Robinson2016-08-231-1/+1
| | | | | The source's voice holds a copy of the last properties it received, so listener updates can make sources recalculate internal properties from that stored copy.
* Avoid a NULL deref when creating 0 auxiliary effect slotsChris Robinson2016-07-261-12/+9
|
* Remove broken autowah effect codeChris Robinson2016-07-261-1/+0
| | | | | It's been disabled forever, and I have no idea how to make it work properly. Better to just redo it when making something that works.
* Avoid using memcpy to copy a single structChris Robinson2016-07-061-3/+3
|
* Use separate arrays for UIntMap keys and valuesChris Robinson2016-07-041-2/+2
|
* Hold the effectslot map lock while handling itChris Robinson2016-05-291-0/+24
|
* Use a linked list for active effect slotsChris Robinson2016-05-291-36/+31
|
* Use the backend lock for the effectstate's deviceUpdate callChris Robinson2016-05-271-8/+4
|
* Avoid duplicate effect state objects in the freelistChris Robinson2016-05-151-12/+25
| | | | | | | If an unapplied update was superceded, it would be placed in the freelist with its effect state object intact. This would cause another update with the same effect state object to be placed into the freelist as well, or worse, cause it to get deleted while in use when the container had its effect state cleared.
* Avoid using a flag to specify if the effect state needs to be updatedChris Robinson2016-05-151-10/+9
| | | | | This fixes a potential missed state change if an update with a new state got replaced with one that doesn't.
* Provide asynchronous property updates for sourcesChris Robinson2016-05-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | This necessitates a change in how source updates are handled. Rather than just being able to update sources when a dependent object state is changed (e.g. a listener gain change), now all source updates must be proactively provided. Consequently, apps that do not utilize any deferring (AL_SOFT_defer_updates or alcSuspendContext/alcProcessContext) may utilize more CPU since it'll be filling out more update containers for the mixer thread to use. The upside is that there's less blocking between the app's calling thread and the mixer thread, particularly for vectors and other multi-value properties (filters and sends). Deferring behavior when used is also improved, since updates that shouldn't be applied yet are simply not provided. And when they are provided, the mixer doesn't have to ignore them, meaning the actual deferring of a context doesn't have to synchrnously force an update -- the process call will send any pending updates, which the mixer will apply even if another deferral occurs before the mixer runs, because it'll still be there waiting on the next mixer invocation. There is one slight bug introduced by this commit. When a listener change is made, or changes to multiple sources while updates are being deferred, it is possible for the mixer to run while the sources are prepping their updates, causing some of the source updates to be seen before the other. This will be fixed in short order.
* Properly load the effect state pointer from the property containerChris Robinson2016-05-131-2/+6
|
* Hold the effect and filter maps while handling effects and filtersChris Robinson2016-05-121-1/+7
|
* Avoid updating the effect state object if it's not changedChris Robinson2016-05-121-13/+21
|
* Provide (mostly) lockless updates for effect slotsChris Robinson2016-05-121-50/+116
| | | | | | | | | | | | | | | | | Similar to the listener, separate containers are provided atomically for the mixer thread to apply updates without needing to block, and a free-list is used to reuse container objects. A couple things to note. First, the lock is still used when the effect state's deviceUpdate method is called to prevent asynchronous calls to reset the device from interfering. This can be fixed by using the list lock in ALc.c instead. Secondly, old effect states aren't immediately deleted when the effect type changes (the actual type, not just its properties). This is because the mixer thread is intended to be real-time safe, and so can't be freeing anything. They are cleared away when updates reuse the container they were kept in, and they don't incur any extra processing cost, but there may be cases where the memory is kept around until the effect slot is deleted.
* Use a lockless method for updating listener and context propertiesChris Robinson2016-05-111-2/+5
| | | | | | | | | | | This uses a separate container to provide the relevant properties to the internal update method, using atomic pointer swaps. A free-list is used to avoid having too many individual containers. This allows the mixer to update the internal listener properties without requiring the lock to protect against async updates. It also allows concurrent read access to the user-facing property values, even the multi-value ones (e.g. the vectors).
* Shorten VECTOR_ITER_ macros to VECTOR_Chris Robinson2016-04-151-3/+3
|
* Move the aligned malloc functions to the common libChris Robinson2016-03-291-0/+2
|
* Store the effect's output buffer in the effect stateChris Robinson2016-03-171-0/+2
|
* Mix to multichannel for effectsChris Robinson2016-01-281-0/+2
| | | | | | This mixes to a 4-channel first-order ambisonics buffer. With ACN ordering and N3D scaling, this makes it easy to remain compatible with effects that only care about mono input since channel 0 is an unattenuated mono signal.
* Update COPYING to the latest ↵François Cami2014-08-181-2/+2
| | | | https://www.gnu.org/licenses/old-licenses/lgpl-2.0.txt to fix the FSF' address Fix the FSF' address in the source
* Use an ATOMIC_INIT macro instead of ATOMIC_LOAD_UNSAFEChris Robinson2014-08-031-1/+1
|
* Explicitly pass the address of atomics and parameters that can be modifiedChris Robinson2014-07-261-6/+6
|
* Use generic atomics in more placesChris Robinson2014-07-221-4/+4
|
* Add macros for generic atomic functionalityChris Robinson2014-07-221-2/+2
|
* Use VECTOR_FIND_IF instead of a manual loopChris Robinson2014-07-061-11/+7
|
* Don't require pre-declaring vector typesChris Robinson2014-07-061-6/+5
|
* Make RefCount a non-integer typeChris Robinson2014-05-141-2/+2
| | | | | It should only be accessed through the appropriate functions to ensure proper atomicity.
* Insert all new effect slots into the active effect slots at onceChris Robinson2014-04-101-26/+27
|
* Remove the click removal buffers for auxiliary effect slotsChris Robinson2014-03-231-2/+0
|
* Increase the vector reserve as needed when pushing in new itemsChris Robinson2014-03-211-1/+1
|
* Add a generic vector interface and use it for the active effect slotsChris Robinson2014-03-211-22/+12
|
* Use C99 inline in more placesChris Robinson2013-11-041-0/+3
|
* Rename VCALL and VCALL0 to V and V0Chris Robinson2013-11-021-4/+4
|
* Modify how VCALL is handledChris Robinson2013-10-281-4/+4
| | | | | | | | | | | Now instead of specifying the arguments as a third argument to the macro, like VCALL(object,function,(arg1, arg2)); they are specified separately after the macro, like VCALL(object,function)(arg1, arg2); Also, VCALL_NOARGS has been removed in favor of VCALL0, which behaves like above but expects an empty argument list (a separate macro is needed to work around preprocessor limitations).
* Remove al_try from alAuxEffectSlot.cChris Robinson2013-10-071-234/+209
|
* Implement the Compressor effectChris Robinson2013-10-031-0/+1
|
* Implement the Autowah effect.Chris Robinson2013-10-031-0/+1
|
* Limit the source step to 10Chris Robinson2013-07-021-1/+1
| | | | | | | | | This means the combination of the buffer frequency, source pitch, and doppler shift can't exceed 10x the device playback frequency. This is needed to keep the mixer from starving with a really high increment, causing small DstBufferSize values that require a lot of iterations.
* Fix up the naming convention of effect methodsChris Robinson2013-05-291-2/+2
|
* Use C99's inline instead of __inlineChris Robinson2013-05-281-1/+1
|
* Store pointers to the getFactory funcs in the mapChris Robinson2013-05-271-12/+15
|