aboutsummaryrefslogtreecommitdiffstats
path: root/al/effects/chorus.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Fix if-comparison (#890)Johan Mattsson2023-07-301-1/+1
|
* Use a variant to hold EAX effect propertiesChris Robinson2023-05-241-20/+6
|
* Replace al::optional with std::optionalChris Robinson2023-05-041-3/+3
|
* Avoid copying to a temporaryChris Robinson2023-03-111-17/+19
|
* Rename some struct members for clarityChris Robinson2023-03-111-2/+2
|
* Simplify committing EAX effect propertiesChris Robinson2023-03-111-27/+14
| | | | | | | | | | There's no need to explicitly clamp to EFX limits when they're the same as or more lenient than EAX, which were already validated when set, or when it's within tolerance of the effect implementation. Also it's generally better to check once all properties for changes and apply them all if one is different, rather than checking and setting each member individually.
* Convert EAX chorus and flanger effectsChris Robinson2023-03-101-190/+180
|
* Add a type indicator to EaxEffectPropsChris Robinson2023-03-091-0/+3
|
* Store the per-version EAX effect state in the base classChris Robinson2023-03-091-41/+49
| | | | | | | | | | | | | | | | This is the start of the refactoring for holding separable per-version EAX effects. Currently the effect state is stored in the effect object, which is instantiated per-type. This makes it impossible for different effects to be assigned on different EAX versions for a given effect slot (e.g. if the app sets a Chorus effect on EAX4 Slot0, it would fail to get or set the EAX1/2/3 reverb properties since it's a Chorus effect object). Seperate per-version effects will allow for switching the OpenAL effect by switching versions. This will provide an extra benefit in being able to delay OpenAL effect initialization until some EAX version has been set, avoiding an extraneous reverb and/or chorus processor for apps that only query some EAX properties but don't set anything (or which only use Slot0, leaving Slot1 with a defaulted Chorus effect running).
* clang-tidy cleanups (#800)Rosen Penev2023-01-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * clang-tidy: use bool literals Found with modernize-use-bool-literals Signed-off-by: Rosen Penev <[email protected]> * clang-tidy: replace std::bind with lambdas Found with modernize-avoid-bind Signed-off-by: Rosen Penev <[email protected]> * clang-tidy: use data() instead of pointer stuff Found with readability-container-data-pointe Signed-off-by: Rosen Penev <[email protected]> * clang-tidy: use empty() Found with readability-container-size-empty Signed-off-by: Rosen Penev <[email protected]> * clang-tidy: remove static in anon namespace Found with readability-static-definition-in-anonymous-namespace Signed-off-by: Rosen Penev <[email protected]> * clang-tidy: remove const return Found with readability-const-return-type Signed-off-by: Rosen Penev <[email protected]> Signed-off-by: Rosen Penev <[email protected]>
* Avoid unnecessary uses of make_optionalChris Robinson2023-01-131-2/+2
|
* [EAX] Use separate FX slot state for each version (#730)Boris I. Bendovsky2022-07-121-8/+8
| | | | | | | * [EAX] Use separate FX slot state for each version [EAX] Don't defer FX slot properties * [EAX_FXSLOT] Use mPropsDirty to defer update [EAX_CONTEXT] Commit all updates on first initialization
* [EAX] Add separate effect state for each version (#705)Boris I. Bendovsky2022-05-241-1011/+388
| | | | | * [EAX] Add separate effect state for each version * [EAX] Don't use EAX call as data member
* Move EAX files to their own sub-directoryChris Robinson2022-05-161-2/+2
|
* Simplify committing EAX propertiesChris Robinson2022-03-051-214/+68
| | | | | | Based on DirectSound's EAX behavior, committing any EAX property commits *all* deferred property changes, not just the object being changed. So applying EAX changes can be handled in one place.
* Ensure deferred EAX effect properties are committedChris Robinson2022-03-041-6/+4
|
* Avoid using ALeffect to manage EaxEffect objectsChris Robinson2022-02-071-21/+10
| | | | Effect slots can just use its EaxEffect directly.
* Move ALSOFT_EAX definition to config.hChris Robinson2022-01-301-8/+3
| | | | And disable it by default for non-Windows targets
* Add EAX extensions (EAX 2.0-5.0, X-RAM) (#632)Boris I. Bendovsky2022-01-301-0/+1240
| | | | | | | | | | | | | | | * Add EAX extensions (EAX 2.0-5.0, X-RAM) * Comment out C++17 leftovers * Remove everything related to patching * Update alsoftrc.sample * Rewrite integration * Fix GCC compilation under Linux * Always reset EAX effect properties when loading it into FX slot
* Add back some more missing includesChris Robinson2021-04-271-0/+2
|
* Update include headersChris Robinson2021-04-271-1/+1
| | | | Don't add alc/ to the include paths.
* Move some functions to coreChris Robinson2021-04-251-0/+3
| | | | And clean up more includes
* Avoid AL types and enums in the effect processorsChris Robinson2020-12-241-20/+46
|
* Move AL EffectProp handling to separate sourcesChris Robinson2020-11-251-0/+250
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-01 12:44:22 +0000