Fix Bug 745: NPE - QTT definition shall be allowd to _follow_ SOF (frame) - Reference QTT via QTT[] passed to frame, validate after parsing.

4 files changed, 75 insertions, 25 deletions

diff --git a/make/scripts/tests.sh b/make/scripts/tests.sh
index 809618ce1..452f28016 100644
--- a/make/scripts/tests.sh
+++ b/make/scripts/tests.sh
@@ -205,7 +205,7 @@ function jrun() {
     #D_ARGS="-Dnewt.debug=all"
     #D_ARGS="-Djogl.debug.GLCanvas -Djogl.debug.GLJPanel"
     #D_ARGS="-Djogl.debug.PNGImage"
-    #D_ARGS="-Djogl.debug.JPEGImage"
+    D_ARGS="-Djogl.debug.JPEGImage"
     #D_ARGS="-Djogl.debug.GLDrawable -Dnativewindow.debug.GraphicsConfiguration -Djogl.debug.CapabilitiesChooser"
     #X_ARGS="-Dsun.java2d.noddraw=True -Dsun.java2d.opengl=True -Dsun.java2d.xrender=false"
     #X_ARGS="-Dsun.java2d.noddraw=True -Dsun.java2d.opengl=false -Dsun.java2d.xrender=false"
@@ -340,7 +340,7 @@ function testawtswt() {
 #testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestGLPointsNEWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestGLMesaBug651NEWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestGLMesaBug658NEWT $*
-testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestX11DefaultDisplay $*
+#testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestX11DefaultDisplay $*
 #testawt com.jogamp.opengl.test.junit.jogl.acore.TestOffscreenLayer01GLCanvasAWT $*
 #testawt com.jogamp.opengl.test.junit.jogl.acore.TestOffscreenLayer02NewtCanvasAWT $*
 #testawt com.jogamp.opengl.test.junit.jogl.acore.TestAddRemove01GLCanvasSwingAWT $*
@@ -526,11 +526,10 @@ testnoawt com.jogamp.opengl.test.junit.jogl.acore.TestX11DefaultDisplay $*
 #testawt com.jogamp.opengl.test.junit.jogl.util.texture.TestTexture01AWT $*
 #testawt com.jogamp.opengl.test.junit.jogl.util.texture.TestTexture02AWT $*
 
-#testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGImage00NEWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGImage01NEWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGJoglAWTCompareNewtAWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGJoglAWTBenchmarkNewtAWT $*
-#testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGTextureFromFileNEWT $*
+testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestJPEGTextureFromFileNEWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestPNGImage01NEWT $*
 #testawt com.jogamp.opengl.test.junit.jogl.util.texture.TestPNGTextureFromFileAWT $*
 #testnoawt com.jogamp.opengl.test.junit.jogl.util.texture.TestPNGTextureFromFileNEWT $*
diff --git a/src/jogl/classes/jogamp/opengl/util/jpeg/JPEGDecoder.java b/src/jogl/classes/jogamp/opengl/util/jpeg/JPEGDecoder.java
index 251291a14..833771dd1 100644
--- a/src/jogl/classes/jogamp/opengl/util/jpeg/JPEGDecoder.java
+++ b/src/jogl/classes/jogamp/opengl/util/jpeg/JPEGDecoder.java
@@ -301,13 +301,15 @@ public class JPEGDecoder {
         private final ArrayHashSet<Integer> compIDs;
         private final ComponentIn[] comps;
         private final int compCount;
+        /** quantization tables */
+        final int[][] qtt;
         int maxCompID;
         int maxH;
         int maxV;
         int mcusPerLine;
         int mcusPerColumn;
 
-        Frame(boolean progressive, int precision, int scanLines, int samplesPerLine, int componentsCount) {
+        Frame(boolean progressive, int precision, int scanLines, int samplesPerLine, int componentsCount, int[][] qtt) {
             this.progressive = progressive;
             this.precision = precision;
             this.scanLines = scanLines;
@@ -315,6 +317,7 @@ public class JPEGDecoder {
             compIDs = new ArrayHashSet<Integer>(componentsCount);
             comps = new ComponentIn[componentsCount];
             this.compCount = componentsCount;
+            this.qtt = qtt;
         }
 
         private final void checkBounds(int idx) {
@@ -322,6 +325,17 @@ public class JPEGDecoder {
                 throw new CodecException("Idx out of bounds "+idx+", "+this);
             }            
         }
+        public final void validateComponents() {
+            for(int i=0; i<compCount; i++) {
+                final ComponentIn c = comps[i];
+                if( null == c ) {
+                    throw new CodecException("Component["+i+"] null");
+                }
+                if( null == this.qtt[c.qttIdx] ) {
+                    throw new CodecException("Component["+i+"].qttIdx -> null QTT");
+                }
+            }
+        }
 
         public final int getCompCount() { return compCount; }
         public final int getMaxCompID() { return maxCompID; }
@@ -357,7 +371,8 @@ public class JPEGDecoder {
     /** The JPEG encoded components */
     class ComponentIn {
         final int h, v;
-        final int[] quantizationTable;
+        /** index to frame.qtt[] */
+        final int qttIdx;
         int blocksPerColumn;
         int blocksPerColumnForMcu;
         int blocksPerLine;
@@ -368,10 +383,10 @@ public class JPEGDecoder {
         BinObj huffmanTableAC;
         BinObj huffmanTableDC;
 
-        ComponentIn(int h, int v, int[] quantizationTable) {
+        ComponentIn(int h, int v, int qttIdx) {
             this.h = h;
             this.v = v;
-            this.quantizationTable = quantizationTable;
+            this.qttIdx = qttIdx;
         }
 
         public final void allocateBlocks(int blocksPerColumn, int blocksPerColumnForMcu, int blocksPerLine, int blocksPerLineForMcu) {
@@ -389,7 +404,7 @@ public class JPEGDecoder {
         }
         
         public final String toString() {
-            return "CompIn[h "+h+", v "+v+", blocks["+blocksPerColumn+", mcu "+blocksPerColumnForMcu+"]["+blocksPerLine+", mcu "+blocksPerLineForMcu+"][64]]";
+            return "CompIn[h "+h+", v "+v+", qttIdx "+qttIdx+", blocks["+blocksPerColumn+", mcu "+blocksPerColumnForMcu+"]["+blocksPerLine+", mcu "+blocksPerLineForMcu+"][64]]";
         }
     }
 
@@ -526,12 +541,14 @@ public class JPEGDecoder {
     }
     public synchronized JPEGDecoder parse(final InputStream inputStream) throws IOException {        
         clear(inputStream);
-        Frame frame = null;
-        int resetInterval = 0;
-        int[][] quantizationTables = new int[0x0F][]; // 4 bits
-        ArrayList<Frame> frames = new ArrayList<Frame>();
+        
+        final int[][] quantizationTables = new int[0x0F][]; // 4 bits
         final BinObj[] huffmanTablesAC = new BinObj[0x0F]; // Huffman table spec - 4 bits
         final BinObj[] huffmanTablesDC = new BinObj[0x0F]; // Huffman table spec - 4 bits
+        // final ArrayList<Frame> frames = new ArrayList<Frame>(); // JAU: max 1-frame
+        
+        Frame frame = null;
+        int resetInterval = 0;
         int fileMarker = readUint16();
         if ( fileMarker != M_SOI ) {
             throw new CodecException("SOI not found, but has marker "+toHexString(fileMarker));
@@ -579,6 +596,7 @@ public class JPEGDecoder {
                 while( count < quantizationTablesLength ) {
                     final int quantizationTableSpec = readUint8(); count++;
                     final int precisionID = quantizationTableSpec >> 4;
+                    final int tableIdx = quantizationTableSpec & 0x0F;
                     final int[] tableData = new int[64];
                     if ( precisionID == 0 ) { // 8 bit values
                         for (int j = 0; j < 64; j++) {
@@ -591,12 +609,15 @@ public class JPEGDecoder {
                             tableData[z] = readUint16(); count+=2;
                         }
                     } else {
-                        throw new CodecException("DQT: invalid table precision "+precisionID+", quantizationTableSpec "+quantizationTableSpec);
+                        throw new CodecException("DQT: invalid table precision "+precisionID+", quantizationTableSpec "+quantizationTableSpec+", idx "+tableIdx);
                     }
-                    quantizationTables[quantizationTableSpec & 0x0F] = tableData;
+                    quantizationTables[tableIdx] = tableData;
+                    if( DEBUG ) {
+                        System.err.println("JPEG.parse.QTT["+tableIdx+"]: spec "+quantizationTableSpec+", precision "+precisionID+", data "+count+"/"+quantizationTablesLength);
+                    }                    
                 }
                 if(count!=quantizationTablesLength){
-                    throw new CodecException("ERROR: QTT format error [count!=Length]");
+                    throw new CodecException("ERROR: QTT format error [count!=Length]: "+count+"/"+quantizationTablesLength);
                 }
                 fileMarker = 0; // consumed and get-next
             }
@@ -604,6 +625,9 @@ public class JPEGDecoder {
 
             case M_SOF0:
             case M_SOF2: {
+                if( null != frame ) { // JAU: max 1-frame
+                    throw new CodecException("only single frame JPEGs supported");
+                }
                 int count = 0;
                 final int sofLen = readUint16(); count+=2; // header length;
                 final int componentsCount;
@@ -613,7 +637,7 @@ public class JPEGDecoder {
                     final int scanLines = readUint16(); count+=2;
                     final int samplesPerLine = readUint16(); count+=2;
                     componentsCount = readUint8(); count++;
-                    frame = new Frame(progressive, precision, scanLines, samplesPerLine, componentsCount);
+                    frame = new Frame(progressive, precision, scanLines, samplesPerLine, componentsCount, quantizationTables);
                     width = frame.samplesPerLine;
                     height = frame.scanLines;
                 }
@@ -622,14 +646,15 @@ public class JPEGDecoder {
                     final int temp = readUint8(); count++;
                     final int h = temp >> 4;
                     final int v = temp & 0x0F;
-                    final int qId = readUint8(); count++;
-                    frame.putOrdered(componentId, new ComponentIn(h, v, quantizationTables[qId]));
+                    final int qttIdx = readUint8(); count++;
+                    final ComponentIn compIn = new ComponentIn(h, v, qttIdx);
+                    frame.putOrdered(componentId, compIn);
                 }
                 if(count!=sofLen){
                     throw new CodecException("ERROR: SOF format error [count!=Length]");
                 }
                 prepareComponents(frame);
-                frames.add(frame);
+                // frames.add(frame); // JAU: max 1-frame
                 if(DEBUG) { System.err.println("JPG.parse.SOF[02]: Got frame "+frame); }
                 fileMarker = 0; // consumed and get-next
             }
@@ -711,14 +736,21 @@ public class JPEGDecoder {
             }
         }
         if(DEBUG) { System.err.println("JPG.parse.2: End of parsing input "+this); }
+        /** // JAU: max 1-frame
         if ( frames.size() != 1 ) {
-            throw new CodecException("only single frame JPEGs supported");
+            throw new CodecException("only single frame JPEGs supported "+this);
+        } */
+        if( null == frame ) {
+            throw new CodecException("no single frame found in stream "+this);
         }
+        frame.validateComponents();
 
         final int compCount = frame.getCompCount();
         this.components = new ComponentOut[compCount];
         for (int i = 0; i < compCount; i++) {
             final ComponentIn component = frame.getCompByIndex(i);
+            // System.err.println("JPG.parse.buildComponentData["+i+"]: "+component); // JAU
+            // System.err.println("JPG.parse.buildComponentData["+i+"]: "+frame); // JAU
             this.components[i] = new ComponentOut( output.buildComponentData(frame, component), 
                                                    (float)component.h / (float)frame.maxH, 
                                                    (float)component.v / (float)frame.maxV );
@@ -834,12 +866,14 @@ public class JPEGDecoder {
             final byte[] r = new byte[64];
 
             for (int blockRow = 0; blockRow < blocksPerColumn; blockRow++) {
-                int scanLine = blockRow << 3;
+                final int scanLine = blockRow << 3;
+                // System.err.println("JPG.buildComponentData: row "+blockRow+"/"+blocksPerColumn+" -> scanLine "+scanLine); // JAU
                 for (int i = 0; i < 8; i++) {
                     lines.add(new byte[samplesPerLine]);
                 }
                 for (int blockCol = 0; blockCol < blocksPerLine; blockCol++) {
-                    quantizeAndInverse(component.getBlock(blockRow, blockCol), r, R, component.quantizationTable);
+                    // System.err.println("JPG.buildComponentData: col "+blockCol+"/"+blocksPerLine+", comp.qttIdx "+component.qttIdx+", qtt "+frame.qtt[component.qttIdx]); // JAU
+                    quantizeAndInverse(component.getBlock(blockRow, blockCol), r, R, frame.qtt[component.qttIdx]);
 
                     final int sample = blockCol << 3;
                     int offset = 0;
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/TestJPEGTextureFromFileNEWT.java b/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/TestJPEGTextureFromFileNEWT.java
index 55e8152ae..82867f9e6 100644
--- a/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/TestJPEGTextureFromFileNEWT.java
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/TestJPEGTextureFromFileNEWT.java
@@ -74,6 +74,8 @@ public class TestJPEGTextureFromFileNEWT extends UITestCase {
     InputStream testTextureStream03CMYK_01;
     InputStream testTextureStream03YCCK_01;
     
+    InputStream testTextureStream04QTTDefPostFrame;
+    
     @Before
     public void initTest() throws IOException {
         {
@@ -132,6 +134,13 @@ public class TestJPEGTextureFromFileNEWT extends UITestCase {
             testTextureStream03YCCK_01 = testTextureUrlConn.getInputStream();
             Assert.assertNotNull(testTextureStream03YCCK_01);
         }
+        {
+            URLConnection testTextureUrlConn = IOUtil.getResource(this.getClass(), "bug745_qttdef_post_frame.jpg");
+            Assert.assertNotNull(testTextureUrlConn);
+            testTextureStream04QTTDefPostFrame = testTextureUrlConn.getInputStream();
+            Assert.assertNotNull(testTextureStream04QTTDefPostFrame);
+        }
+        
     }
 
     @After
@@ -142,7 +151,10 @@ public class TestJPEGTextureFromFileNEWT extends UITestCase {
         testTextureStream01YUV422h_Prog = null;
         testTextureStream02YUV420_Base = null;
         testTextureStream02YUV420_Prog = null;
-        testTextureStream02YUV420_BaseGray = null;        
+        testTextureStream02YUV420_BaseGray = null;
+        testTextureStream03CMYK_01 = null;
+        testTextureStream03YCCK_01 = null;        
+        testTextureStream04QTTDefPostFrame = null;
     }
 
     public void testImpl(boolean useFFP, final InputStream istream) throws InterruptedException, IOException {
@@ -241,7 +253,7 @@ public class TestJPEGTextureFromFileNEWT extends UITestCase {
     @Test
     public void test02YUV420BaseGray_ES2() throws InterruptedException, IOException {
         testImpl(false, testTextureStream02YUV420_BaseGray);        
-    }    
+    }
 
     @Test
     public void test03CMYK_01_ES2() throws InterruptedException, IOException {
@@ -251,6 +263,11 @@ public class TestJPEGTextureFromFileNEWT extends UITestCase {
     public void test03YCCK_01_ES2() throws InterruptedException, IOException {
         testImpl(false, testTextureStream03YCCK_01);        
     }    
+
+    @Test
+    public void test04QTTDefPostFrame_ES2() throws InterruptedException, IOException {
+        testImpl(false, testTextureStream04QTTDefPostFrame);        
+    }    
     
     public static void main(String args[]) throws IOException {
         for(int i=0; i<args.length; i++) {
diff --git a/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/bug745_qttdef_post_frame.jpg b/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/bug745_qttdef_post_frame.jpg
new file mode 100644
index 000000000..1c7009321
--- /dev/null
+++ b/src/test/com/jogamp/opengl/test/junit/jogl/util/texture/bug745_qttdef_post_frame.jpg